Task upgraded from "Drupal calls should be avoided in classes, use dependency injection instead" to "PHPCS compatibility"

Adding gitlab CI and converting to MR.

CommentFileSizeAuthor
#2 drupal_calls_should_be_avoided_3419791.patch7.22 KBmaithri shetty

Issue fork taxonomy_manager-3419791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Maithri Shetty created an issue. See original summary.

maithri shetty’s picture

maithri shetty commented
Assigned: maithri shetty » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal_calls_should_be_avoided_3419791.patch7.22 KB

VladimirAus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Title: Drupal calls should be avoided in classes, use dependency injection instead » PHPCS compatibility
Status: Needs review » Needs work

Task upgraded from "Drupal calls should be avoided in classes, use dependency injection instead" to "PHPCS compatibility"

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Issue summary: View changes

VladimirAus opened merge request !25

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Related issues: +#3446269: Enable GitLab CI automated testing

sokru made their first commit to this issue’s fork.

sokru’s picture

sokru commented
Status: Needs work » Needs review

The PHPCS job is now green. I tried to keep changes minimal so it would be easy to review (so no constructor property promotion).

I fully ignored ExportTermsForm since the functionality is not working at the moment. I would recommend fixing the CS issues on same issues as where the export functionality will be done.

jhuhta’s picture

jhuhta commented
Status: Needs review » Reviewed & tested by the community

The changes look good and the touched functionalities still work, given that ExportTermsForm is ignored as @sokru said.

Phpstan and the likes will be addressed separately I assume.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed! 🥂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.