Problem/Motivation

When using the recurring_events_registrations view provided by Recurring Events Views submodule, an incomplete list of Registrants is shown if the series uses Series Registration.

Steps to reproduce

  • enable the Recurring Events Views submodule so that the event instance registrations list at /event/{eventinstance}/registrations is replaced by the recurring_events_registrations view.
  • create an event with Series Registration and more than one instance
  • register one registrant to each instance in newly created series
  • go to the Registrations tab for each event instance and see that the view does not show all the Registrants from the whole series, but just the Registrants from that particular instance

Proposed resolution

Figure out how to configure the view to show all Registrants from the series if set to Series Registration OR show a different view display for Series Registration events and do not show the default, incorrect Registrant view

CommentFileSizeAuthor
#6 3419694--seriesRegistrationViews--6.patch1.69 KBchrisla

Issue fork recurring_events-3419694

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

endless_wander created an issue. See original summary.

owenbush’s picture

owenbush commented

Thank you for raising this issue. I see the problem now. There is a function `recurring_events_views_views_query_alter` which alters the query for the registrant list view to ensure that it displays registrants for all instances in a series registration series.

The problem is that previously the view had an id of 'registrations' but that was eventually changed in a later release of recurring events to be 'recurring_events_registrations' so it was better namespaced.

The code in the function was not updated to use that ID.

I'll get that addressed for you.

owenbush opened merge request !85

owenbush’s picture

owenbush commented
Status: Active » Needs review

Please try out a patch from the MR and let me know whether it works for you.

chrisla’s picture

chrisla commented

Heads up this will no longer apply against latest 2.0.x branch

chrisla’s picture

chrisla commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3419694--seriesRegistrationViews--6.patch1.69 KB

New patch works against 2.0.2. Sorry can't get access to make MR right now.

@maintainers, could this get merged into 2.0 branch?

  • plopesc committed 120b97e2 on 3.0.x 
    Issue #3419694 by owenbush, chrisla: Registrants view does not show...

  • plopesc committed 3ad99e74 on 2.0.x 
    Issue #3419694 by owenbush, chrisla: Registrants view does not show...
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed

Patch in #6 applied against 2.0.x and 3.0.x branches.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chrisla’s picture

chrisla commented

Misreported error.

chrisla’s picture

chrisla commented

After upgrading to 3.0, this code seems to break the "individual registration" views now.

In the code, it is assumed that $registration_creation_service->getRegistrationType() will return a string, but it returns an object now. That means that the switch case afterwards always fires the default case. This causes the registrations views to show all registrants from all instances of a series when "individual registration" is active. This should not be the case.

I believe the fix to use $registration_creation_service->getRegistrationType()->value solves this.

chrisla’s picture

chrisla commented

Fixed in https://www.drupal.org/project/recurring_events/issues/3626621