Problem/Motivation

Pipelines are ok cause phpstan pipeline is allowed to fail.
It would be great if its pipeline was also ok though.

Proposed resolution

According to the last CI pipelines, https://git.drupalcode.org/project/migrate_upgrade/-/jobs/528168 we only have to replace Drupal calls by dependency injections.

We also will have to add a phpstan.neon file, cause using dependencies injection will bring errors such as:

Unsafe usage of new static(). 💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static

Since it is a best practice in Drupal, we will just ignore that kind of errors

Issue fork migrate_upgrade-3419025

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

MacSim created an issue. See original summary.

MacSim opened merge request !6

benstallings made their first commit to this issue’s fork.

jeremy1606 made their first commit to this issue’s fork.

jerech’s picture

jerech commented
Status: Active » Needs review

The phpstan errors have been fixed:
https://git.drupalcode.org/issue/migrate_upgrade-3419025/-/jobs/7758082

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work

Tests are failing.

jerech’s picture

jerech commented
Status: Needs work » Needs review

The MR6 is ready for review. Thanks

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for the contributions

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • heddn committed 52ffd889 on 4.0.x authored by macsim 
    chore: #3419025 Fix phpstan errors

By: benstallings
By: jeremy1606
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.