The module is compatible with Drupal 10. Either a new branch should be created for Drupal 10, or the existing branch should define itself as compatible with Drupal 10.

CommentFileSizeAuthor
#8 3418156-d10-8.patch1.33 KBchucksimply
#5 3418156-d10-5.patch725 bytesdineshkumarbollu

Issue fork short_scale_formatter-3418156

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chucksimply created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: Feature request » Support request
Issue summary: View changes

Except I missed some changes, the code is already compatible with Drupal 10. The module just needs to declare itself compatible with Drupal 10.

I do not have a site (even a test site) running on Drupal 10, so I cannot verify if there is anything that needs to be fixed.

chucksimply’s picture

chucksimply commented

Would it be possible to declare the D10 compatibility in the info file on a new dev release? This way I don't have to do workarounds getting it installed with composer.

dineshkumarbollu’s picture

dineshkumarbollu commented

The module is compatible with D10 only below issues are there.Will Provide patch.

FILE: web/modules/contrib/short_scale_formatter/short_scale_formatter.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^9.2 is not compatible   
                    with the next major version of Drupal core. See             
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

FILE: web/modules/contrib/short_scale_formatter/composer.json

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Parse error in composer.json. Having a composer.json is not 
                    a requirement in general, but if there is one, it should be 
                    valid. See https://drupal.org/node/2514612.                 
--------------------------------------------------------------------------------
dineshkumarbollu’s picture

dineshkumarbollu commented
StatusFileSize
new 3418156-d10-5.patch725 bytes
chucksimply’s picture

chucksimply commented

Thanks for the patch! Installed, but when visiting the fields page... received this error.

Fatal error: Could not check compatibility between Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ShortScaleFormatter::create(Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) and Drupal\Core\Field\FormatterBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition), because class Drupal\short_scale_formatter\Plugin\Field\FieldFormatter\ContainerInterface is not available in /web/modules/contrib/short_scale_formatter/src/Plugin/Field/FieldFormatter/ShortScaleFormatter.php on line 58

chucksimply’s picture

chucksimply commented

Needed the use statement

use Symfony\Component\DependencyInjection\ContainerInterface;

added to the top of src/Plugin/Field/FieldFormatter/ShortScaleFormatter.php

I'll try uploading a new patch here shortly. Once this statement was added, seems to be working as expected!

chucksimply’s picture

chucksimply commented
StatusFileSize
new 3418156-d10-8.patch1.33 KB

Updated new patch to account for the above.

chucksimply’s picture

chucksimply commented
Status: Active » Needs review

New patching working flawlessly.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Drupal 10 Support? » Make the module compatible with Drupal 10
Category: Support request » Task
Issue summary: View changes

apaderno opened merge request !2

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

  • apaderno committed 2ef08ddc on 1.0.x 
    Issue #3418156: Make the module compatible with Drupal 10
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.