Problem/Motivation

Youtube live stream links like this do not work https://youtube.com/live/8defxBZ50Hw

I've modified the regex in YouTube.php slightly and got it to work.

CommentFileSizeAuthor
#4 video_embed_field--support-live--3417567--4.patch741 bytesnicolas s.
#3 After Patch.png1.79 MBsandeep_k
#3 Before Patch.png122.4 KBsandeep_k
#2 video_embed_field--support-live--3417567--2.patch736 bytesloze

Issue fork video_embed_field-3417567

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

loze created an issue. See original summary.

loze’s picture

loze commented
Status: Active » Needs review
StatusFileSize
new video_embed_field--support-live--3417567--2.patch736 bytes

Here's a patch

sandeep_k’s picture

sandeep_k commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.png122.4 KB
new After Patch.png1.79 MB

@loze, I've Tested shared Patch- video_embed_field--support-live--3417567--2.patch on Drupal versions- 9.5.11 & 10.1.9-dev. The patch was applied successfully and looks good to me.

Testing Steps:

  • Enable/Install the Video Embed Field module.
  • Go to> Structure> Content type> Add Video Embed field to a content type.
  • Go to Content> Create new node-Add Live Stream URL as mentioned (Added before result)
  • Download the shared patch & apply.
  • Go to> Content Type- Create new node-Add Live Stream URL in the video embed field.

Testing Results:
After applying the patch, I successfully added the YouTube Live Stream URL in the Embed field. RTBC+

nicolas s.’s picture

nicolas s. commented
StatusFileSize
new video_embed_field--support-live--3417567--4.patch741 bytes

Hi,

Patch works with Drupal 10.4.x and url youtube live url but not working with youtube embed like this https://www.youtube.com/embed/tEfCoTb4e2Q

I propose a new patch

mably’s picture

mably commented

Could you provide an MR please?

nicolas s. changed the visibility of the branch 3417567-support-youtube-live to hidden.

nicolas s. opened merge request !63

nicolas s. changed the visibility of the branch 3417567-support-youtube-live to hidden.

nicolas s. opened merge request !64

nicolas s.’s picture

nicolas s. commented

It's done @mably

  • 20a2dba0 committed on 3.0.x 
    Issue #3417567: Support Youtube Live urls
mably’s picture

mably commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Fixed
mably’s picture

mably commented
Version: 3.0.x-dev » 8.x-2.x-dev
Status: Fixed » Reviewed & tested by the community

@nicolas-s could you create another issue to add the embed/ url handling that was present in your original patch?

mably’s picture

mably commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Fixed
nicolas s.’s picture

nicolas s. commented

Issue created : https://www.drupal.org/project/video_embed_field/issues/3512575

mably’s picture

mably commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mably closed merge request !63