Problem/Motivation

At #3417482: [Meta] Pass Eslint validations we are aiming to have all the eslint validation checks passing for the Examples module.

On this issue, we'll be focused on the tour_example sub-module

Initial errors detected by 27/01/2024

/modules/tour_example/config/install/tour.tour.tour-example.yml
  41:77  error  Trailing spaces not allowed  no-trailing-spaces
  42:73  error  Trailing spaces not allowed  no-trailing-spaces
  43:75  error  Trailing spaces not allowed  no-trailing-spaces
  45:77  error  Trailing spaces not allowed  no-trailing-spaces
  46:79  error  Trailing spaces not allowed  no-trailing-spaces
  47:62  error  Trailing spaces not allowed  no-trailing-spaces
  50:77  error  Trailing spaces not allowed  no-trailing-spaces

Proposed resolution

  1. Check the parent issue for detailed instructions about how to run eslint locally
  2. Run eslint against the submodule: tour_example
  3. Fix the issues found and make a MR with the fixes.

Issue fork examples-3417514

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jlbellido created an issue. See original summary.

jlbellido’s picture

I've created an initial MR solving the errors reported by Eslint on the Tour module. I think it is ready now.

jlbellido’s picture

Status: Active » Needs review

apaderno made their first commit to this issue’s fork.

  • apaderno committed 7248a870 on 4.0.x authored by jlbellido
    Issue #3417514: Fix the errors reported by eslint for the Tour Example...
avpaderno’s picture

Title: Pass Eslint validations: Tour example » Pass Eslint validations: Tour Example
Status: Needs review » Fixed
avpaderno’s picture

Title: Pass Eslint validations: Tour Example » Pass ESLint validations: Tour Example

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.