Metadata: Selection list filter breaks the filter in the Asset Library

@Rajeshreeputra - Requested some changes, please take a look.

Updated as per review feedback, requesting review.

Verified recent changes and it looks good to me. I would request another sets of eyes.

I encountered an issue when using the patch while switching between grid and table with selected filters because the JavaScript was attempting to access the form element with id="views-exposed-form-acquia-dam-asset-library-widget". However, in some cases, it seems the form didn’t exist on the page, which resulted in a JavaScript error when trying to manipulate the form’s elements.

Error Message (with private information removed):
An error occurred while attempting to process https://your-site-url/admin/content/media-dam-widget/asset_library_type?media_library_opener_id=media_library.opener.editor&media_library_allowed_types[0]=documents_asset&media_library_allowed_types[1]=image_asset&...&_wrapper_format=drupal_ajax: document.getElementById(...) is null.

Root Cause:
The JavaScript was trying to interact with a form that wasn't present on the page at the time of execution, causing a null reference error.

Possible Solution:
By adding an early return when the form is not found, the script avoids further execution and prevents errors:

if (!form) {
  return;
}

This ensures that the script only proceeds if the form exists, avoiding the null reference issue. It worked for me, but you all might have more context on how to properly resolve it. I’m just sharing my input in case it helps.

I’ve attached the .diff file for context and the image of the original issue (with private information removed).

I've encountered both of these issues:

• The "Metadata: Selection list" views filter doesn't work in combination with any other views filter (either the "Search" filter or another "Metadata: Selection list" filter)
• The "Clear Filter" button provided in the Media Library UI doesn't clear filters aside from the default "Search" filter

I'm also running into:

• The "DAM Assets: Property value" sort does not appear to work (though perhaps I'm using an incorrect property path?)
• The "Metadata: Selection list" views filter may be doing partial matching, e.g. the value "Abc" matches both "Abc" and "Abcdef"

I'm attaching an example of a view that exhibits these issues. Here's what my exposed filters and sorts look like:

I find that:

• When I enter a search term and no other filters, I get the expected results
• When I select a single value from my "Content Source" dropdown (a "Metadata: Selection list" filter) and no other search/filters, I get the expected results
• When I enter a search term and select a value from my "Content Source" dropdown, I get results matching the search term but NOT filtered by the "Content Source" metadata value

On top of that:

• When I select "Image" from my "Asset Type" dropdown (a "Metadata: Selection list" filter) and no other search/filters, I get results for "Image" assets and also "Image, purchased" assets (which suggests this is a substring match??)
• When I change the "Sort by" or "Sort order" dropdowns, the sort order does not change (regardless of any other filters applied)

Neither of the changes proposed in the MRs on this issue resolve my problems -- MR 30 throws a php error, and MR 75 clears the additional exposed filters but can't handle the exposed sorts.

This issue should now be fixed against the 1.1.x branch instead of 1.0.x, as it is actively maintained.

Thanks! I tested these latest changes and found that:

• Fixed: "Search", and multiple "Metadata: Selection list" filters now work in combination with each other
• Fixed: The "Clear Filter" button now clears the "Search" filter and the "Metadata: Selection list" filters
• Not working: Selecting "Image" from one of our "Metadata: Selection list" filters still matches assets with the metadata value "Image" OR the metadata value "Image, purchased"
• Not working: Sorting does not work
• Not working: The "Clear Filter" button does not reset the exposed sort form elements -- and highlights them in red with the messages "The submitted value All in the Sort by element is not allowed." and "The submitted value All in the Order element is not allowed."

I have also found that filter values containing an ampersand are not handled correctly. Specifically, one of our DAM select lists contains values like "Places | Classroom & Education". When this is selected as a filter, I get an error on the filter select list, no results, and the error message "The submitted value Places | Classroom in the image_classification element is not allowed."

Validated changed of MR197 and can confirm following items have been fixed:

1. Fixed: "Search", and multiple "Metadata: Selection list" filters now work in combination with each other
2. Fixed: The "Clear Filter" button now clears the "Search" filter and the "Metadata: Selection list" filters
3. Fixed: Selecting "Image" from one of our "Metadata: Selection list" filters still matches assets with the metadata value "Image" OR the metadata value "Image, purchased"
4. Fixed: Sorting does not work
5. Fixed: The "Clear Filter" button does not reset the exposed sort form elements -- and highlights them in red with the messages "The submitted value All in the Sort by element is not allowed." and "The submitted value All in the Order element is not allowed."

Hence requesting review.

Hello @becw,

With respect to your issue:

I have also found that filter values containing an ampersand are not handled correctly. Specifically, one of our DAM select lists contains values like "Places | Classroom & Education". When this is selected as a filter, I get an error on the filter select list, no results, and the error message "The submitted value Places | Classroom in the image_classification element is not allowed."

This is also fixed.

Validated changes in MR!197 and it fixes the items listed in #21.

I have validated all the issues raised in this ticket, and everything is working fine.
Filters used are mentioned in the screenmshot

The latest work in MR!197 is working great for me!

• Fixed: "Search", and multiple "Metadata: Selection list" filters now work in combination with each other
• Fixed: The "Clear Filter" button now resets all of the exposed form elements, including the sort and sort direction select lists
• Fixed: Sorting now works
• Not working: Using the "Metadata: Selection list" filter with values that contain ampersands

I've attached screenshots of the remaining issue, but if you'd prefer I could open a separate ticket.

Hello @becw,

I have verified with "Metadata: Selection list" with field "Usage right" and don't see any issue even if I have asset tagged with label that contains ampersands, please see the below screenshot.

Also, could you please let us know how you are creating filter "Image Classification" and which filed being used for this filter?

Multiple test failures, so moving to NW

Fixed failing test, requesting review.

Tests and code looks good. Merged!