Problem/Motivation

The option to attach the JSONEditor form with Shadow DOM is no longer used or maintained within the module, so the setting and related logic should be removed.

Steps to reproduce

  • Navigate to /admin/config/user-interface/patternkit/json
  • Observe the presence of "Use the Shadow DOM" checkbox

Proposed resolution

  • Remove the "Use the Shadow DOM" setting checkbox from the settings form
  • Update exported configuration to remove the setting
  • Remove related JS attachment logic

Remaining tasks

User interface changes

  • The "Use the Shadow DOM" setting no longer exists on the JSON Pattern Library Settings form

API changes

None

Data model changes

  • The "Use the Shadow DOM" setting is removed from exported configuration
CommentFileSizeAuthor
#4 5234_Retest.odt331.69 KBminsharm

Issue fork patternkit-3415095

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

slucero created an issue. See original summary.

slucero’s picture

Issue summary: View changes
Status: Active » Needs review
minsharm’s picture

StatusFileSize
new331.69 KB

Retested the issue and result looks good to me on both D9 as well as on D10.

Steps to reproduce

  • Navigate to /admin/config/user-interface/patternkit/json
  • Observe the presence of "Use the Shadow DOM" checkbox

Results: The JSON patternkit setting form no longer displays the shadow DOM checkbox

minsharm’s picture

Issue summary: View changes
slucero’s picture

Status: Needs review » Reviewed & tested by the community

  • slucero committed f49822de on 9.1.x
    Issue #3415095 by slucero, minsharm: Remove Shadow DOM Editor Attachment
    
slucero’s picture

Status: Reviewed & tested by the community » Fixed

Merged for inclusion in the Beta 9 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.