Problem/Motivation

Drupal CI is deprecated and prone to problems. GitLab CI is the future; let's adopt it!

Proposed resolution

Get a standard GitLab CI pipeline passing. I'm certain that some of the code quality checks (like PHPStan) will fail, but we can fix those in follow-up issues and disable them for now. Getting tests passing is probably more important.

Issue fork project_browser-3415079

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

phenaproxima opened merge request !424

lostcarpark’s picture

lostcarpark commented

I'm disappointed about skipping phpcs and phpstan. I understand there's work to do there, but failures of them don't block a build, so I would have thought it okay to leave them enabled to encourage people to fix the issues.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review

I ended up having to disable nearly all the lint jobs, as predicted, for various reasons. I think they can be fixed in follow-ups, though!

lostcarpark’s picture

lostcarpark commented

I just made a minor tweak to .gitlab-ci.yml to move the parallel section above the drupalicon comment, and add a comment above it. Should make no difference to the functionality, but I think people are likely to expect the dropalicon to be at the bottom of the file.

However, when the tests ran, the FunctionalJavascript test failed.

I reran just that test and it passed the second time.

Wondering could it be the failing because they are running in parallel, or is something causing that particular test to fail some of the time?

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Needs work

I would like to leave DrupalCI.yml in there until we have feature parity in GitLab CI - that could come later, though, and i would merge this as long as we also ran Drupal CI.

lostcarpark’s picture

lostcarpark commented
Status: Needs work » Needs review

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

Ship it! You guys rule. Can't wait to get linting back and drop this all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.