In order to be compatible with the wide SDC ecosystem, do we also extract data from the JSON schema “examples” property when there are no stories ?
If we do that, we will need to override ComponentPluginManager in ui_patterns_library to alter the definitions.

Still this subject to fix:

What do we do if there a not the same number of examples in props?

  • We ignore missing examples? (current situation)
  • We repeat the last example?
  • We do a matrix? For example, 2 props, one with 2 examples, one with 3 examples: 3 stories.?
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Title: [2.0.0-alpha2] » [2.0.0-alpha2] JSON schema examples property
pdureau’s picture

Let's override the componentpluginmanager again in ui_patterns_library, and make it extends ui_patterns one

pdureau’s picture

Status: Active » Needs work

DONE:

  • componentpluginmanager added with first draft of JSON schema examples property and otehr stuff
  • split of templates (not in the scope of this issue, but let's do it anyway)

What do we do if there a not the same number of examples in props?

  • We ignore missing examples? (current situation)
  • We repeat the last example?
  • We do a matrix? For example, 2 props, one with 2 examples, one with 3 examples: 3 stories.?
pdureau’s picture

Title: [2.0.0-alpha2] JSON schema examples property » [2.0.0-alpha3] JSON schema examples property
pdureau’s picture

Title: [2.0.0-alpha3] JSON schema examples property » [2.0.0-alpha3] JSON schema examples property (& split library tempaltes)

This branch also have commits about splitting library templates !

pdureau’s picture

Title: [2.0.0-alpha3] JSON schema examples property (& split library tempaltes) » [2.0.0-alpha3] JSON schema examples property (& split library templates)
pdureau’s picture

Splitting library templates task is moved to #3438387: [2.0.0-alpha3] Split Library templates into smaller ones

pdureau’s picture

Title: [2.0.0-alpha3] JSON schema examples property (& split library templates) » [2.0.0-alpha3] JSON schema examples property
pdureau’s picture

Title: [2.0.0-alpha3] JSON schema examples property » [2.0.0-beta1] JSON schema examples property

Moved to beta1

pdureau’s picture

pdureau’s picture

Issue summary: View changes

Still working on it.

Testing with https://www.drupal.org/project/prototype and not convinced because the results are not visually great.

pdureau’s picture

Title: [2.0.0-beta1] JSON schema examples property » [2.0.0-beta2] JSON schema examples property

Moved to beta2, with the related Library issues. However, we may cancel this change if the results don't match the added complexity.

pdureau’s picture

Title: [2.0.0-beta2] JSON schema examples property » [2.0.0-beta3] JSON schema examples property

Because we plan to extends the plugin manager, let's wait to see what will happen with the service decorator in #3469808: [2.0.0-beta5] Use decorator instead overwriting the component plugin service

pdureau’s picture

Title: [2.0.0-beta3] JSON schema examples property » [2.0.0-beta4] JSON schema examples property
pdureau’s picture

Title: [2.0.0-beta4] JSON schema examples property » [2.0.0-beta5] JSON schema examples property
pdureau’s picture

Title: [2.0.0-beta5] JSON schema examples property » [2.1.0] JSON schema examples property
Assigned: pdureau » Unassigned
Status: Needs work » Active

Let's start again, with a service decorator instead of the first proposal, following #3469808: [2.0.0-beta5] Use decorator instead overwriting the component plugin service

pdureau’s picture

Title: [2.1.0] JSON schema examples property » [2.2.0] JSON schema examples property
pdureau’s picture

Title: [2.2.0] JSON schema examples property » JSON schema examples property

let's do it ASAP because display builder needs it for early beta phase

This may be related to #3551586: ComponentPluginManager decorator incorrectly calls parent instead of decorated service because we need a decorator in ui_patterns_library

pdureau’s picture

Status: Active » Needs review
pdureau’s picture

Assigned: Unassigned » pdureau
Status: Needs review » Needs work

Testing with SDC themes found in the wild. Some crazy stuff over there. So, let's try to extends the logic.

pdureau’s picture

Assigned: pdureau » Unassigned
Status: Needs work » Needs review
pdureau’s picture

Assigned: Unassigned » christian.wiedemann

just_like_good_vibes made their first commit to this issue’s fork.

just_like_good_vibes’s picture

Assigned: christian.wiedemann » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.