Closed (fixed)
Project:
UI Patterns (SDC in Drupal UI)
Version:
2.0.x-dev
Component:
UI Patterns Library
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
15 Jan 2024 at 13:34 UTC
Updated:
13 Nov 2025 at 10:39 UTC
Jump to comment: Most recent
Comments
Comment #2
pdureau commentedComment #3
pdureau commentedLet's override the componentpluginmanager again in ui_patterns_library, and make it extends ui_patterns one
Comment #4
pdureau commentedDONE:
What do we do if there a not the same number of examples in props?
Comment #5
pdureau commentedComment #6
pdureau commentedThis branch also have commits about splitting library templates !
Comment #7
pdureau commentedComment #8
pdureau commentedSplitting library templates task is moved to #3438387: [2.0.0-alpha3] Split Library templates into smaller ones
Comment #9
pdureau commentedComment #10
pdureau commentedMoved to beta1
Comment #11
pdureau commentedSee also #3455354: [2.0.0-beta4] Add a stories specific discovery
Comment #13
pdureau commentedStill working on it.
Testing with https://www.drupal.org/project/prototype and not convinced because the results are not visually great.
Comment #14
pdureau commentedMoved to beta2, with the related Library issues. However, we may cancel this change if the results don't match the added complexity.
Comment #15
pdureau commentedBecause we plan to extends the plugin manager, let's wait to see what will happen with the service decorator in #3469808: [2.0.0-beta5] Use decorator instead overwriting the component plugin service
Comment #16
pdureau commentedComment #17
pdureau commentedComment #18
pdureau commentedLet's start again, with a service decorator instead of the first proposal, following #3469808: [2.0.0-beta5] Use decorator instead overwriting the component plugin service
Comment #19
pdureau commentedComment #20
pdureau commentedlet's do it ASAP because display builder needs it for early beta phase
This may be related to #3551586: ComponentPluginManager decorator incorrectly calls parent instead of decorated service because we need a decorator in
ui_patterns_libraryComment #21
pdureau commentedComment #22
pdureau commentedTesting with SDC themes found in the wild. Some crazy stuff over there. So, let's try to extends the logic.
Comment #23
pdureau commentedComment #24
pdureau commentedComment #27
just_like_good_vibes