Problem/Motivation

Remove uses of book from from test, excluding Update tests.

Steps to reproduce

$ grep --exclude-dir={fixtures,book,node_modules,vendor,themes} -riw book core | grep Test | grep -vi migrat | grep book

These are the files

core/modules/views/tests/src/Kernel/TestViewsTest.php
core/tests/Drupal/KernelTests/Core/Asset/LibraryDiscoveryIntegrationTest.php
core/tests/Drupal/KernelTests/Core/Config/ConfigImporterTest.php

UpdatePathTestBaseFilledTest.php is not to be done in this issue.

Proposed resolution

Examine each usage and decide how to keep the test coverage.

core/modules/views/tests/src/Kernel/TestViewsTest.php - ??
core/tests/Drupal/KernelTests/Core/Asset/LibraryDiscoveryIntegrationTest.php - changed to test theme
core/tests/Drupal/KernelTests/Core/Config/ConfigImporterTest.php - changed to use History module

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3414637

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes

No, core/modules/image/tests/src/Functional/ImageStylesPathAndUrlTest.php does not need to be changed.

Abhijith S made their first commit to this issue’s fork.

Abhijith S opened merge request !6170

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs work

I left a question in the MR.

quietone’s picture

quietone commented
Status: Needs work » Needs review

I meant NR for another opinion

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Left some comments but based on how we handled Tour removal we will need to use a test module vs another contrib. Which should also be used in the spot @quietone brought up a concern about lost coverage.

quietone’s picture

quietone commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback appears to be addressed

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Issue credits

  • larowlan committed 5d87e70d on 11.x 
    Issue #3414637 by Abhijith S, quietone, smustgrave: Remove usages of...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x - thanks

larowlan closed merge request !6170

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.