I just upgraded a site from D9 to 10 and while debugging some mysterious access check errors I noticed webform/modules/webform_image_select/src/Controller/WebformImageSelectImagesController.php and webform/modules/webform_options_custom/src/Controller/WebformOptionsCustomController.php are missing a TRUE/FALSE. During my upgrade I used Upgrade Status, but somehow it didn't flag these accessChecks.

I am not sure this is a bug (so I marked this as a Task), but it seems to me these access checks should be explicitly set. I have attached a patch for webform_image_select and webform_options_custom.

CommentFileSizeAuthor
#5 3413542-empty-accesschecks-in--2.patch1.28 KBcaspervoogt
#2 3414542-accesschecks-missing-truefalse.patch1.39 KBcaspervoogt

Issue fork webform-3413542

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

caspervoogt created an issue. See original summary.

caspervoogt’s picture

caspervoogt commented
Issue summary: View changes
StatusFileSize
new 3414542-accesschecks-missing-truefalse.patch1.39 KB
caspervoogt’s picture

caspervoogt commented

I just noticed that src/Entity/Webform.php and src/EntityListBuilder/WebformEntityListBuilderSortLabelTrait.php also have empty accessChecks. I may make a patch for that one shortly.

caspervoogt’s picture

caspervoogt commented
Title: accessChecks missing TRUE/FALSE in webform_image_select and webform_options_custom » empty accessChecks in webform_image_select, webform_options_custom, WebformEntityListBuilderSortLabelTrait.php
Issue summary: View changes
caspervoogt’s picture

caspervoogt commented
StatusFileSize
new 3413542-empty-accesschecks-in--2.patch1.28 KB
jrockowitz’s picture

jrockowitz commented
Status: Active » Reviewed & tested by the community

The last submitted patch, 2: 3414542-accesschecks-missing-truefalse.patch, failed testing. View results

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 3413542-empty-accesschecks-in--2.patch, failed testing. View results

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review

jrockowitz opened merge request !446

  • jrockowitz committed 1c2aeddc on 6.2.x 
    Issue #3413542 by caspervoogt, jrockowitz: empty accessChecks in...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed
jrockowitz’s picture

jrockowitz commented
Version: 6.2.2 » 6.2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.