Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
9 Jan 2024 at 12:09 UTC
Updated:
10 Apr 2025 at 10:49 UTC
Jump to comment: Most recent
Comments
Comment #2
vishal.kadamThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report.To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #3
vishal.kadamComment #4
avpadernoAs a side note, please check you set Git to use the email address associated to your drupal.org account. Differently, your commits will not be associated to your account.
Comment #5
avpadernoRemember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.
Comment #6
skpal commentedComment #7
avpadernoSince this application has been created by shubhamsprasad, we expect that any status change is done by shubhamsprasad, who is the only person who can make commits in the project for the time this application is open.
Comment #8
shubhamsprasad commentedComment #9
rushikesh raval commentedI am changing the issue priority as per issue priorities.
Comment #10
solideogloria commentedThe code looks good to me. There aren't a lot of commits on the dev branch for some reason. There are more commits on 1.0.3.
Comment #11
avpadernoThank you for your contribution and for your patience with the review process!
I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.
These are some recommended readings to help you with maintainership:
You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank the dedicated reviewers as well.
Comment #12
avpadernoComment #14
avpadernoComment #15
avpaderno