When JS/CSS aggrigation/preprocess is enabled, for the gtag.js and gtm.js I get an error: "Only file JavaScript assets with preprocessing enabled can be optimized.".
related to the Drupal 10.2.1.

CommentFileSizeAuthor
#5 3413105_js_preprocess_error.patch544 bytesnamisha jadhav
#2 3413105-2.patch519 bytesnortmas

Issue fork google_tag-3413105

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nortmas created an issue. See original summary.

nortmas’s picture

nortmas commented
StatusFileSize
new 3413105-2.patch519 bytes

I believe it's just a workaround.

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented

Same error here

summit’s picture

summit commented

Hi, will this patch be committed?

namisha jadhav’s picture

namisha jadhav commented
StatusFileSize
new 3413105_js_preprocess_error.patch544 bytes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Please help fixing this issue as root cause: #3416508: Skip generating aggregates that won't be used for stale asset requests

anybody opened merge request !125

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

I created a MR with the workaround from #5 until the core issue (#3416508: Skip generating aggregates that won't be used for stale asset requests) is resolved.
Basically, the core issue fix will have the same result as using the MR, at least as long as Drupal won't minify JS with preprocess: false.

Semantically the hotfix here is wrong, but technically it's fine.

sircosta’s picture

sircosta commented

Same issue confirmed on a Drupal 10.5.4 production site.
The error occurs with JS aggregation enabled, and disabling it resolves the problem.
The workaround of setting { preprocess: true } on gtag.js and gtm.js fixes the issue permanently.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Closed (works as designed)

This is NOT an issue in google_tag module! It's the linked core issue in combinatin with COOKiES / Klaro module!
See https://www.drupal.org/project/drupal/issues/3416508#comment-16340916 for details.

The attached patch does NOT fix it. So I'll close this one. Having { preprocess: false } WITHOUT , minified: true is totally fine!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.