Problem/Motivation

The Core UI translations for the redesigned add content type page in Core are still missing on localize.drupal.org. So nobody can translate them right now. That should be fixed a.s.a.p. In many languages, we have achieved a 100 % translated core now. So we can tell if something is missing with ease. We try to honour users, especially newcomers by providing as many translations as possible so they do not need to switch the UI to English anywhere if they do not want to. But here we missed the extraction of source strings, so they are unavailable for translation, anywhere.

Steps to reproduce

  1. Install Drupal
  2. Set up a second language (E.g. German, where Core is translated 100%)
  3. Switch to the language you installed
  4. Go to: /admin/structure/types/manage/article/fields/add-field
  5. Check all field types available, including sub-options for strings in English

Result: The page isn't fully translated because there are no source strings on l.d.o

missing translations for add new field
Installed and tested on 2024-01-01 / 12:00 PM GMT with Drupal Core 10.20

Proposed resolution

check the code and make missing strings available on localize.drupal.org

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
Screenshot 2024-01-01 134335.png92.38 KBjoachim namyslo

Issue fork potx-3411529

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Joachim Namyslo created an issue. See original summary.

joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Title: Translations for add filed dialog missing » Translations on add filed page missing
Issue summary: View changes
joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Issue summary: View changes
joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Issue summary: View changes
joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Issue summary: View changes
grienauer’s picture

grienauer
he/him
Primary language German
Location Vienna
commented

I will try to fine one, tho help us with this issue.

joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented

Awesome Thx.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Project: Drupal core » localize.drupal.org
Version: 10.2.x-dev » 7.x-1.x-dev
Component: language system » Existing language complaint

I think this is in the wrong issue queue. Also @drumm might be able to help you out.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Issue summary: View changes

Fixed a few typo's in the IS.

joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented

Is it?

I do not know, bewcause I do not know if t() was just forgotton here or that has something to do with the extraction process.
But we'll figure that out.

Thanks for moving that issue.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

If the strings are not set as translatable it's indeed a core issue.

If it's not showing on l.d.o like the IS is suggesting this should be the right queue 🙂 we can always move it back!

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: localize.drupal.org » Translation template extractor
Component: Existing language complaint » Code

These strings look like they are from https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/file/...

You can see 10.2.0 was parsed at https://localize.drupal.org/translate/projects/drupal/releases and the file containing that file was processed without warnings https://localize.drupal.org/translate/projects/drupal/releases/557916#so...

potx module has this, and I do not see something that matches to mark it as translatable:
https://git.drupalcode.org/project/potx/-/blob/7.x-3.x/yaml_translation_...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Fwiw https://git.drupalcode.org/project/drupal/-/blame/11.x/core/lib/Drupal/C... these are declared translatable here

fjgarlin’s picture

fjgarlin commented

I guess that'll make them translatable in each individual site vs having this module detect them without needing to visit the page where they're at. I'm not sure of this though.

I'm going to implement Neil's suggestion.

fjgarlin opened merge request !9

fjgarlin’s picture

fjgarlin commented
Version: 7.x-1.x-dev » 7.x-3.x-dev

fjgarlin closed merge request !9

fjgarlin opened merge request !10

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

I added the suggestion from #12 in https://git.drupalcode.org/project/potx/-/merge_requests/10/diffs

Not sure how to test this though. Please review.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Change looks simple enough. Will leave it at NR so others can have a look as well.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Translations on add filed page missing » field_type_categories.yml translatable strings missing from potx

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 7.x-3.x-dev » 8.x-1.x-dev
Status: Needs review » Patch (to be ported)

Merged to Drupal 7. We need a Drupal 8 port of this as well for the Drupal 8 branch, thanks!

BramDriesen opened merge request !11

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Patch (to be ported) » Needs review

I *think* I did this correctly on the existing issue fork 🙂

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Looks good, thanks!

drumm’s picture

drumm
he/him
Location NY, US
commented

Deployed and this is ready to translate: https://localize.drupal.org/translate/languages/de/translate?sid=2983012

joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented
Related issues: +#3412541: field_type_advanced descriptive texts still not translateable
joachim namyslo’s picture

joachim namyslo
Primary language German
Location Kulmbach 🇩🇪 🇪🇺
commented

Thank you all.

That was really quick.

Some parts of this page are still not translateable see: #3412541

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.