[1.0.x] Entity limit extend

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

I am changing the issue priority as per issue priorities.

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml entity_limit_e
xtend/

FILE: entity_limit_extend/entity_limit_extend.module
--------------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 13 LINES
--------------------------------------------------------------------------------
 21 | ERROR | String concat is not required here; use a single string instead
 22 | ERROR | String concat is not required here; use a single string instead
 27 | ERROR | String concat is not required here; use a single string instead
 28 | ERROR | String concat is not required here; use a single string instead
 29 | ERROR | String concat is not required here; use a single string instead
 30 | ERROR | String concat is not required here; use a single string instead
 32 | ERROR | String concat is not required here; use a single string instead
 33 | ERROR | String concat is not required here; use a single string instead
 34 | ERROR | String concat is not required here; use a single string instead
 37 | ERROR | String concat is not required here; use a single string instead
 41 | ERROR | String concat is not required here; use a single string instead
 45 | ERROR | String concat is not required here; use a single string instead
 46 | ERROR | String concat is not required here; use a single string instead
--------------------------------------------------------------------------------


FILE: entity_limit_extend/src/EntityLimitInspector.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
 189 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 194 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 199 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 211 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 226 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 248 | WARNING | Line exceeds 80 characters; contains 93 characters
 280 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 285 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 298 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 313 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------

2. FILE: entity_limit_extend.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

3. FILE: src/EntityLimitInspector.php

// dump("user access");.

Remove commented debug code.

Review feedback changes should be pushed to the review branch [1.0.x].

main is acceptable as branch name, but it is not yet fully supported on drupal.org. For the moment, it is better to avoid it.

I am changing priority as per Issue priorities.

This thread has been idle, in the Needs work state, with no activity for some months. Are you still interested in being able to opt projects into security advisory policy?

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.

Let's keep this application open for two more months.

This thread has been idle, in the Needs work state with no activity for about eight months or more; the application has been created about 11 months ago or more. Therefore, I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.