Problem/Motivation

This is part of the CSS modernization initiative.

Currently consolidating several into 1

Steps to reproduce

NA

Proposed resolution

Remove @nest from claro stylesheets

Remaining tasks

User interface changes

NA - nothing should change

API changes

NA

Data model changes

NA

Release notes snippet

NA

Issue fork drupal-3410681

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

hritik parihar’s picture

Working on this :)

hritik parihar’s picture

I'd like some help on this :)

finnsky’s picture

@Hritik Parihar
thank you for work here!

You need to run `yarn && yarn build && yarn lint:css --fix` in `/core` to be sure that css compiled well and avoid lint pipeline failures.

finnsky’s picture

Status: Active » Needs work

sidharth_soman made their first commit to this issue’s fork.

sidharth_soman’s picture

Status: Needs work » Needs review

Added a commit for the lint fixes.

smustgrave’s picture

Status: Needs review » Needs work

Lint failures still happening.

sidharth_soman’s picture

Sorry for the noise, but I was under the assumption that the lint check had passed as indicated by this - https://git.drupalcode.org/issue/drupal-3410681/-/pipelines/68290

Or are there some linting errors that aren't picked up and the compilation check fails because of that (without giving any specific error)?
Thanks in advance.

finnsky’s picture

Failure happends in this pipeline job https://git.drupalcode.org/issue/drupal-3410681/-/jobs/534027

You need to run `yarn build` and check which css should be changed. Also if css changed better to check if this place has no regressions.

shweta__sharma’s picture

Issue tags: +Novice

ahsannazir made their first commit to this issue’s fork.

ahsannazir’s picture

Status: Needs work » Needs review

Raised MR for fixing above issue.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs manual testing

Searching for remaining @nest in claro theme and all have been addressed.

During manual testing
Checked user edit form to change password
Edited the content view testing views ui
Created an Article content
Verified page title change + shortcut seem fine.
Content view showed table is good.

Compiler caused some weird moves but nothing that I see should break anything.

larowlan’s picture

Status: Reviewed & tested by the community » Needs work

Couple of minor comments

rodrigoaguilera’s picture

Issue tags: +Barcelona2024

The Drupal Contribution Mentoring team is triaging issues for DrupalCon Barcelona 2024, and we are reserving this issue for Mentored Contribution during the event.

After September 27, 2024, this issue returns to being open to all. Thanks!

The comments in the MR need to be looked at and figure out a way forward.

brandonlira’s picture

Hello everyone,

I noticed that this issue is currently marked as 'Needs work' due to some unresolved comments regarding CSS ordering and linting errors. I would like to contribute, but I want to confirm the best approach before making any changes.

Could someone clarify what exactly needs to be addressed at this point? Should we focus only on removing @nest, or is there a need to revert the CSS order changes as well?

Any guidance would be greatly appreciated. Thanks!

brandonlira’s picture

Status: Needs work » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

charlliequadros made their first commit to this issue’s fork.

charlliequadros’s picture

Status: Needs work » Needs review

Hi everyone,

I did the rebase on the MR, and there were several changes.
I'm not sure if it would be better to create a new MR with the updates.
If that would be safer, please let me know, and I'll make the change.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new6.9 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

charlliequadros’s picture

Status: Needs work » Needs review

Hey everyone, the issue with the Stylelint in the CSS was caused by the order of the elements, so I fixed it. You can check the change in this link. It was correct before, but I might have mistakenly modified it during the merge.

Additionally, I removed some @nest rules that were added to the light theme. Could someone validate if any further changes are needed?

I’d also like to understand why this issue is happening. I’ve noticed it occurring in several issues I contributed to. If possible, I’d love to learn how this works and help fix it if necessary.

smustgrave’s picture

Status: Needs review » Needs work

Still 1 nit change on the MR, since it's from a core committer going to put back into NW.

charlliequadros’s picture

Status: Needs work » Needs review

Hi @smustgrave

Initially removed a blank line that was marked as "out of scope", but it turns out it's required to pass the CSS linting tests. The line has been kept to avoid breaking the test suite.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Believe feedback has been addressed

  • nod_ committed 293fe02e on 11.x
    Issue #3410681 by charlliequadros, hritik parihar, ahsannazir,...
nod_’s picture

Status: Reviewed & tested by the community » Fixed

Committed 293fe02 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nod_’s picture

Version: 11.x-dev » 11.2.x-dev
Status: Closed (fixed) » Fixed

backported to 11.2.x for #3523078: Update prettier/PostCSS/stylelint for 11.2

Committed b989a95 and pushed to 11.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.