Closed (fixed)
Project:
Drupal core
Version:
11.2.x-dev
Component:
Claro theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Dec 2023 at 16:52 UTC
Updated:
17 Jun 2025 at 06:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
smustgrave commentedComment #4
hritik parihar commentedWorking on this :)
Comment #6
hritik parihar commentedI'd like some help on this :)
Comment #7
finnsky commented@Hritik Parihar
thank you for work here!
You need to run `yarn && yarn build && yarn lint:css --fix` in `/core` to be sure that css compiled well and avoid lint pipeline failures.
Comment #8
finnsky commentedComment #10
sidharth_soman commentedAdded a commit for the lint fixes.
Comment #11
smustgrave commentedLint failures still happening.
Comment #12
sidharth_soman commentedSorry for the noise, but I was under the assumption that the lint check had passed as indicated by this - https://git.drupalcode.org/issue/drupal-3410681/-/pipelines/68290
Or are there some linting errors that aren't picked up and the compilation check fails because of that (without giving any specific error)?
Thanks in advance.
Comment #13
finnsky commentedFailure happends in this pipeline job https://git.drupalcode.org/issue/drupal-3410681/-/jobs/534027
You need to run `yarn build` and check which css should be changed. Also if css changed better to check if this place has no regressions.
Comment #14
shweta__sharma commentedComment #16
ahsannazir commentedRaised MR for fixing above issue.
Comment #17
smustgrave commentedSearching for remaining @nest in claro theme and all have been addressed.
During manual testing
Checked user edit form to change password
Edited the content view testing views ui
Created an Article content
Verified page title change + shortcut seem fine.
Content view showed table is good.
Compiler caused some weird moves but nothing that I see should break anything.
Comment #18
larowlanCouple of minor comments
Comment #19
rodrigoaguileraThe Drupal Contribution Mentoring team is triaging issues for DrupalCon Barcelona 2024, and we are reserving this issue for Mentored Contribution during the event.
After September 27, 2024, this issue returns to being open to all. Thanks!
The comments in the MR need to be looked at and figure out a way forward.
Comment #20
brandonlira commentedHello everyone,
I noticed that this issue is currently marked as 'Needs work' due to some unresolved comments regarding CSS ordering and linting errors. I would like to contribute, but I want to confirm the best approach before making any changes.
Could someone clarify what exactly needs to be addressed at this point? Should we focus only on removing @nest, or is there a need to revert the CSS order changes as well?
Any guidance would be greatly appreciated. Thanks!
Comment #21
brandonlira commentedComment #22
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #24
charlliequadros commentedHi everyone,
I did the rebase on the MR, and there were several changes.
I'm not sure if it would be better to create a new MR with the updates.
If that would be safer, please let me know, and I'll make the change.
Comment #25
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #26
charlliequadros commentedHey everyone, the issue with the Stylelint in the CSS was caused by the order of the elements, so I fixed it. You can check the change in this link. It was correct before, but I might have mistakenly modified it during the merge.
Additionally, I removed some @nest rules that were added to the light theme. Could someone validate if any further changes are needed?
I’d also like to understand why this issue is happening. I’ve noticed it occurring in several issues I contributed to. If possible, I’d love to learn how this works and help fix it if necessary.
Comment #27
smustgrave commentedStill 1 nit change on the MR, since it's from a core committer going to put back into NW.
Comment #28
charlliequadros commentedHi @smustgrave
Initially removed a blank line that was marked as "out of scope", but it turns out it's required to pass the CSS linting tests. The line has been kept to avoid breaking the test suite.
Comment #29
smustgrave commentedBelieve feedback has been addressed
Comment #31
nod_Committed 293fe02 and pushed to 11.x. Thanks!
Comment #34
nod_backported to 11.2.x for #3523078: Update prettier/PostCSS/stylelint for 11.2
Committed b989a95 and pushed to 11.2.x. Thanks!