The attached zip provides Diff UI support for the Profile module, with a dependency on this module ie. Entity Diff UI. I'm not expecting to put this code elsewhere so just leaving it here in case anyone wants to pick it up. It requires the #2599014: Create the revision UI for profiles patch.

CommentFileSizeAuthor
#2 profile_diff.zip6.22 KBsime

Comments

sime created an issue. See original summary.

sime’s picture

sime
any/any
Location Melbourne
commented
StatusFileSize
new profile_diff.zip6.22 KB
sime’s picture

sime
any/any
Location Melbourne
commented

Just leaving a note here that this custom code is throwing phpstan errors and I notice there are quite a lot in entity_diff_ui.

 ------ ----------------------------------------------------------------------------------------------
  Line   contrib/entity_diff_ui/src/Form/RevisionOverviewForm.php
 ------ ----------------------------------------------------------------------------------------------
  208    Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface:
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use
         \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.
  211    Call to deprecated method loadRevision() of class Drupal\Core\Entity\EntityStorageInterface:
         in drupal:10.1.0 and is removed from drupal:11.0.0. Use
         \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.
sime’s picture

sime
any/any
Location Melbourne
commented
Title: Code for Profile Diff UI » Add support Profile Diff UI
Category: Task » Feature request
Status: Closed (won't fix) » Needs review

The attached code is working really well for us, and I would like to see this added to the entity_diff_ui as a submodule. If this is of interest I'll add it as an MR.

mingsong’s picture

mingsong
Location 🇦🇺
commented

Thanks @Si,

Yes, please create a MR, we can go from there.

mingsong’s picture

mingsong
Location 🇦🇺
commented
Status: Needs review » Needs work
sime’s picture

sime
any/any
Location Melbourne
commented
Status: Needs work » Closed (won't fix)

As discussed at DrupalSouth we'll keep the code custom since there is a generic revision UI on the way. The zip file is still here for anyone to use.