Problem/Motivation

Domain path is failing Gitlab CI phpcs test

Steps to reproduce

View the recent test report:
https://git.drupalcode.org/issue/domain_path-3402507/-/jobs/356370

Proposed resolution

Review the issues identified and resolve them in the code.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork domain_path-3409106

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tporchia created an issue. See original summary.

tporchia opened merge request !23

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Active » Needs work
Related issues: +#3409866: Resolve phpunit testing errors on Gitlab CI automated tests, +#3409798: Resolve eslint issues from Gitlab CI automated testing

Hi @tporchia88, I've committed the phpunit and eslint fixes, but can't merge the phpcs changes. Could you please pull the latest changes to your MR? Thanks in advance!

quadrexdev’s picture

quadrexdev
Location Lutsk
commented
Title: Resolve phpcs failing test » Resolve failed validation jobs

Let's fix all the failing validation stuff over there :)

mradcliffe made their first commit to this issue’s fork.

mradcliffe opened merge request !33

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review

Tests are going to fail on Drupal 11 until domain module has a new release since the one included in the tests doesn't have #3479098: Fix newly reported phpcs issues in latest pipeline yet.

I added drupal 10 (Previous major) testing.

mably’s picture

mably commented
Assigned: tporchia » Unassigned
Category: Bug report » Task
Status: Needs review » Fixed

Gitlab CI jobs are passing fine now. Thanksç!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.