Add gitlab CI

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

deepakkm created an issue. See original summary.

Prashant.c made their first commit to this issue’s fork.

prashant.c’s picture

Status: Active » Needs review

Incorporated a .gitlab-ci.yml file into the project's root directory by utilizing the Drupal Association's template.gitlab-ci.yml contents. Continuously learning about it as I progress.

Thanks

vipin.mittal18 made their first commit to this issue’s fork.

ptmkenny’s picture

Status: Needs review » Needs work

@Prashant.c Thanks for adding this.

@vipin.mittal18 It looks like you fixed some coding standards and PHPStan issues. However, I think that is out of scope for this MR. This is specifically about adding GitLab CI, not fixing the problems identified by GitLab CI, which should be separate issues.

Adding the CI template is very easy if that is the only file in the commit to review.

vipin.mittal18’s picture

Hello @ptmkenny, I have modified gitlabci.yml file only. Refer https://git.drupalcode.org/project/schema_metatag/-/merge_requests/49/di.... Coding standards are previously committed by someone.

ptmkenny’s picture

There are still irrelevant changes not related to the GitLab CI template.

Also, it seems that the comments have been stripped from the latest version of the template (https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...), but I think the comments provide useful information.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

Status: Needs work » Needs review

I've raised MR!55 against 3.0.x-dev branch please review and merge this one to both 8.x-2.x and 3.0.x branches if possible.

poorva’s picture

RTBC

poorva’s picture

Status: Needs review » Reviewed & tested by the community
ptmkenny’s picture

Status: Reviewed & tested by the community » Needs work

This needs work.

@poorva If you mark RTBC, you need to state why.

ankitv18’s picture

Hi @ptmkenny,
Can you please review MR!55: https://git.drupalcode.org/project/schema_metatag/-/merge_requests/55/diffs and if it possible can you merge this one?

ptmkenny’s picture

@ankitv18 Ok, I reviewed MR55. This looks better since it adds the template and leaves the tests as a separate issue, but I think the links to the documentation should be restored.

ankitv18’s picture

@ptmkenny I've updated the MR!55 https://git.drupalcode.org/project/schema_metatag/-/merge_requests/55/diffs , please review and check whether this one can be merged to 3.0.x-dev

ankitv18’s picture

Status: Needs work » Needs review

Rajeshreeputra made their first commit to this issue’s fork.

ptmkenny’s picture

Status: Needs review » Needs work

@Rajeshreeputra Your addition of the previous major test needs additional configuration since this module requires PHP 8.

rajeshreeputra’s picture

Status: Needs work » Needs review

ankitv18 changed the visibility of the branch 3408108-add-gitlab-ci to hidden.

damienmckenna’s picture

Status: Needs review » Reviewed & tested by the community
Parent issue: » #3368792: Plan for Schema Metatag 3.0.2

This looks good, thank you.

damienmckenna’s picture

damienmckenna’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Thank you all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.