Closed (fixed)
Project:
Schema.org Metatag
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Dec 2023 at 07:16 UTC
Updated:
27 Jun 2024 at 14:54 UTC
Jump to comment: Most recent
Add gitlab CI
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
prashant.cIncorporated a .gitlab-ci.yml file into the project's root directory by utilizing the Drupal Association's template.gitlab-ci.yml contents. Continuously learning about it as I progress.
Thanks
Comment #6
ptmkenny commented@Prashant.c Thanks for adding this.
@vipin.mittal18 It looks like you fixed some coding standards and PHPStan issues. However, I think that is out of scope for this MR. This is specifically about adding GitLab CI, not fixing the problems identified by GitLab CI, which should be separate issues.
Adding the CI template is very easy if that is the only file in the commit to review.
Comment #7
vipin.mittal18Hello @ptmkenny, I have modified gitlabci.yml file only. Refer https://git.drupalcode.org/project/schema_metatag/-/merge_requests/49/di.... Coding standards are previously committed by someone.
Comment #8
ptmkenny commentedThere are still irrelevant changes not related to the GitLab CI template.
Also, it seems that the comments have been stripped from the latest version of the template (https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...), but I think the comments provide useful information.
Comment #11
ankitv18 commentedI've raised MR!55 against 3.0.x-dev branch please review and merge this one to both 8.x-2.x and 3.0.x branches if possible.
Comment #12
poorva commentedRTBC
Comment #13
poorva commentedComment #14
ptmkenny commentedThis needs work.
@poorva If you mark RTBC, you need to state why.
Comment #15
ankitv18 commentedHi @ptmkenny,
Can you please review MR!55: https://git.drupalcode.org/project/schema_metatag/-/merge_requests/55/diffs and if it possible can you merge this one?
Comment #16
ptmkenny commented@ankitv18 Ok, I reviewed MR55. This looks better since it adds the template and leaves the tests as a separate issue, but I think the links to the documentation should be restored.
Comment #17
ankitv18 commented@ptmkenny I've updated the MR!55 https://git.drupalcode.org/project/schema_metatag/-/merge_requests/55/diffs , please review and check whether this one can be merged to 3.0.x-dev
Comment #18
ankitv18 commentedComment #20
ptmkenny commented@Rajeshreeputra Your addition of the previous major test needs additional configuration since this module requires PHP 8.
Comment #21
rajeshreeputraComment #23
damienmckennaThis looks good, thank you.
Comment #24
damienmckennaComment #26
damienmckennaCommitted. Thank you all.