Problem/Motivation

I'm trying to update to php 8.3 but hit an issue with composer core dev dependencies. phpspec/prophecy v1.17.0 does not support php 8.3 which is required by phpspec/prophecy-phpunit which is a core dev dependency.

Steps to reproduce

Proposed resolution

Upgrade to https://github.com/phpspec/prophecy/releases/tag/v1.18.0

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3406622

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

mstrelan’s picture

mstrelan commented

https://github.com/phpspec/prophecy/issues/607

cilefen’s picture

cilefen commented
Title: phpspec/prophecy v1.17.0 does not support php 8.3 » [upstream] phpspec/prophecy v1.17.0 does not support PHP 8.3
andypost’s picture

andypost
he/him
Primary language Russian
commented
Parent issue: #3366286: [META] Make Drupal 10.2/11 compatible with PHP 8.3 » #3330874: [11.x] [policy] Require PHP 8.3 for Drupal 11
Related issues: +#3366286: [META] Make Drupal 10.2/11 compatible with PHP 8.3
cilefen’s picture

cilefen commented
Category: Bug report » Task

I assume this is a task given that.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

We have a issue created in phpspec/prophecy and PR associated.

andypost’s picture

andypost
he/him
Primary language Russian
commented

released https://github.com/phpspec/prophecy/releases/tag/v1.18.0

andypost opened merge request !5725

andypost’s picture

andypost
he/him
Primary language Russian
commented
Title: [upstream] phpspec/prophecy v1.17.0 does not support PHP 8.3 » Upgrade phpspec/prophecy to v1.18.0 to support PHP 8.3
Status: Active » Needs review

Filed MR for fix, needs backport to 10.2

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks @andypost for keeping up with all these 8.3 issues!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Guessing we did not catch this in GitLab CI because we run composer install on the default version of PHP (currently 8.2), and then reuse the same vendor directory artifact on the real PHP version in the tests? Should we change the pipeline, or write a build test maybe, to ensure that composer install is successful on all supported versions?

edit: or perhaps it's because of this in the root composer.json?

        "platform": {
            "php": "8.1.0"
        },

andypost opened merge request !5727

andypost’s picture

andypost
he/him
Primary language Russian
commented

Opened MR to test but then figured out that composer checking on phpspec/prophecy-phpunit which require prophecy itself

Very probably composer does not check platform reqs for indirect dependencies

mondrake’s picture

mondrake
Location 🇮🇹
commented
Priority: Normal » Critical
Issue tags: +PHPUnit 10

+1, also needed for PHPUnit 10 support. Bumping to critical, we need to have this in 10.2.0 I assume.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

As this is just a lockfile change I think we should roll this into #3405696: Update composer dependencies for Drupal 10.2.0 where we are going to do a final round of all PHP dependency updates.

andypost closed merge request !5727

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Closed (duplicate)

Added changes to #3405696: Update composer dependencies for Drupal 10.2.0

andypost closed merge request !5725