Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2023 at 15:15 UTC
Updated:
28 Feb 2024 at 15:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jastraat commentedQuick clarifying questions on this one:
Should the convert to webp also be added to the default config from the Drupal core image module? (That would include the large, medium, thumbnail, etc styles.)
And is this truly just to add something like the following as an additional entry in the "effects" section of all image.style.*.yml files in core install profiles?
Comment #3
andypostYes, amd it should be the last effect
Comment #4
andypostComment #5
catch@jastraat yes makes sense to do those here too, I updated the issue title.
Comment #6
prashant.cCan you provide guidance on where to implement these modifications? Are they intended to be made within the
image.style.[name].ymlfiles located inside profile config files? For instance, in the case of Umami, would these changes be applied in files such ascore/profiles/demo_umami/config/install/image.style.large_3_2_2x.yml, as well as other relevant image style configuration files? Thank you.Comment #7
deepak.cms commented@catch, I added the WEBP image effect to default styles that comes with Standard Installation from image module.
Comment #8
catch@deepak.cms - that looks fine. Can you also apply the same thing to the Umami install profile image styles? It would also be good to use an MR rather than a patch here (Drupal.org is moving away from patches).
Comment #9
deepak.cms commentedSure, I will update it in MR. Thanks
Comment #10
deepak.cms commentedComment #11
catchSounds good - moving to needs work since there's already some code here.
Comment #13
deepak.cms commented@catch, MR created please review.
Comment #14
catchComment #15
marvil07 commentedCI reports some errors at
ConfigSchemaTestandResponsiveImageFieldDisplayTesttests.Both of them seem to be relevant, so moving to NW.
Several of them may be about actually changing the test, that was assuming a different context, like the png string match.
Copying here the relevant output from each of them in CI output.
Comment #16
deepak.cms commentedHi @marvil07,
I updated the test cases for two image effects in the default styles. Please review it again.
Thanks
Comment #17
deepak.cms commentedComment #18
smustgrave commentedSurprised tests passed but don’t believe we should be shipping config with uuids.
Comment #19
nireneko commented@smustgrave Checking the current config files (https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/image... and https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/image... for example) the uuids of the image effects are there, I'd say it's ok.
Comment #20
smustgrave commentedMissing some updates
There's an image.style in
media_library
demo_umami/optional
standard profile
Comment #21
deepak.cms commentedHi @smustgrave,
Updated all image styles. Please review again.
Thanks
Comment #22
djsagar commentedComment #23
catchThis doesn't need tests, it's just a change to the default config.
Comment #24
deepak.cms commentedComment #25
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #26
deepak.cms commentedComment #27
smustgrave commentedCurrent MR has failures.
Comment #29
kostyashupenkoSeems rebase didn't help. After local investigation also no results. No errors on spellcheck. Can you guide me if you will have an ability to fix it - what was a cause of it?
Comment #30
kostyashupenkoCI reports in spellcheck job are not so informative
Comment #31
andypostI started new pipeline and it passed, also extended
core/profiles/standard/tests/src/Functional/StandardTest.phptest for shipped effectsAs the #23 said no reason for test, I still sure standard profile needs at least this small addition
Comment #32
smustgrave commentedhttps://www.drupal.org/project/drupal/issues/3401988#comment-15402750
A workaround was posted here.
Comment #34
smustgrave commentedNew pipeline seemed to do the trick. Believe all feedback has been addressed
Comment #35
quietone commentedI'm triaging RTBC issues. I read the IS and the comments. I didn't find any unanswered questions.
I read the MR and I don't have any questions. I then applied the diff and searched core to ensure that all image styles are updated.
Why are these files not changes?
Comment #36
smustgrave commented@quietone those already contain the code
Example > core/profiles/demo_umami/config/install/image.style.scale_crop_7_3_small.yml
Comment #37
smustgrave commentedRestoring status.
Comment #39
catchAdded a change record; https://www.drupal.org/node/3421405 and committed/pushed to 11.x, thanks!
Comment #40
longwaveNice work, tagging this as a highlight for the release announcement.