After I enabled JSON:API, the endpoint for "linkcheckerlink" returns a 500
Error
Parameter \"entity\" for route \"jsonapi.linkcheckerlink--linkcheckerlink.individual\" must match \"[^/]++\" (\"\" given) to generate a corresponding URL.
LinkChecker link type entity doesn't implement uuid in it's base table
1. Enable JSON:API
2. Navigate to /jsonapi/linkcheckerlink/linkcheckerlink
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff_2-3.txt | 1.16 KB | boulaffasae |
| #3 | 3405194-3.patch | 3.48 KB | boulaffasae |
| #2 | 3405194-2.patch | 2.22 KB | boulaffasae |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
boulaffasae commentedComment #3
boulaffasae commentedI also added view permission, it should be a custom permission instead of true by default :)
Comment #4
eiriksmAwesome 👍 Thanks for the patch!
Would be nice to have:
- The changes in a merge request
- some tests for this
Comment #7
quadrexdevAdded a merge request with the changes from #3 + added a simple Kernel test to verify it's working.
Please review
Comment #8
quadrexdevOops, changed status to needs review before tests passed so reverting it back
Comment #9
quadrexdevOk, now it's passing.
So after applying a patch from #3 all the users had access to view the linkchecker entity (and that was the issue why LinkCheckerLinkAccessTest was failing). I reverted this part cuz the viewing operation is not supposed to be allowed for all the users, right?
Please review
Comment #11
quadrexdevMerged in 2.0.x