Problem/Motivation

There is no .gitlab-ci.yml configuration file in the project.

"GitLab CI uses .gitlab-ci.yml file in the root of the project to configure testing. If you are familiar with the configuration files for Travis CI, GitHub Actions, or even custom DrupalCI yml files, you will find this quite similar."

Steps to reproduce

Review source code, confirm no .gitlab-ci.yml file is present at project root.

Proposed resolution

Create a file using the template provided in the d.o instructions:

https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr...

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork metatag-3404463

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pilot3 created an issue. See original summary.

pilot3 opened merge request !95

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The original MR was created from the 2.0.x and against the 8.x-1.x branch, so I edited it to go against the 2.0.x branch. The tests are running again, we'll see how it goes.

pilot3’s picture

pilot3 commented
Status: Active » Needs review
pilot3’s picture

pilot3 commented
Status: Needs review » Needs work
nikolay shapovalov’s picture

nikolay shapovalov commented

Failed tests aren't dangerous and can be fixed in follow up task.
phpunit jobs takes 11 minutes because contrib by default runs them not parallel. Lets use concurrency/run-tests.sh, see https://git.drupalcode.org/project/flag/-/merge_requests/58/diffs

Adding phpstan.neon file and ignore phpstan "Unsafe usage of new static()." error, is also good idea.

nikolay shapovalov’s picture

nikolay shapovalov commented

I create separate issue to fix PHPunit tests #3413633: Fix tests for, compatibility with Drupal 10.2

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Adding Gitlab CI configuration file to configure automated testing » Adding Gitlab CI configuration file to configure automated testing (D10+)
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Adding Gitlab CI configuration file to configure automated testing (D10+) » Add Gitlab CI test file (D10+)
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
Parent issue: » #3370435: Plan for Metatag 2.0.1

I think this is ready.

nikolay shapovalov’s picture

nikolay shapovalov commented
Status: Needs review » Reviewed & tested by the community

DamienMcKenna, thanks for fixing tests.
Changes in the MR looks good.
I am not sure about changes in method MetatagTagTypesTest::todoTestUrl(), but I leave it up to you.
I would completely remove this method.

Mark this as RTBC.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

RTBC +1

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.