Problem/Motivation
Since updating to version 2 (and also 1.5) we found that the global search input action fields were being modified by facets pretty paths. The facets_pretty_paths_form_views_exposed_form_alter function in the module file seems to modify the action in this way which then causes the search functionality to not work except when the user is on the search results page.
Steps to reproduce
If you have a site with a global exposed form for search you should see that versions 1.5 and 2 of facets pretty paths causes the action of the form to be replaced thus breaking the search functionality.
Proposed resolution
I propose that we remove the newly added facets_pretty_paths_form_views_exposed_form_alter function from the module file. If there is some functionality that is still required that will not have this adverse effect the community is welcome to improve the function and post patches here so that we can get a balanced solution. A patch will follow promptly in the comments.
Remaining tasks
Review the patch, possibly provide further improvements on the solution and testing by the community.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | form_actions_break_for_global_search_fields_2-3402446-2.patch | 1.79 KB | roaldnel |
Issue fork facets_pretty_paths-3402446
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
roaldnel commentedHere is the patch for version 2.
Comment #3
johan den hollander commentedComment #6
rajeshreeputraOpened MR for easy review and merge.
Comment #7
joseph.olstadlooking into this now
Comment #8
joseph.olstadThis is a regression caused by
#3122188: Views exposed sort filters does not sort with facets
reverting 3122188
Thank you everyone above.
Comment #9
joseph.olstadComment #10
joseph.olstadComment #11
joseph.olstadrelease to follow shortly
Comment #12
joseph.olstadhttps://www.drupal.org/project/facets_pretty_paths/releases/2.0.0