Problem/Motivation

Since updating to version 2 (and also 1.5) we found that the global search input action fields were being modified by facets pretty paths. The facets_pretty_paths_form_views_exposed_form_alter function in the module file seems to modify the action in this way which then causes the search functionality to not work except when the user is on the search results page.

Steps to reproduce

If you have a site with a global exposed form for search you should see that versions 1.5 and 2 of facets pretty paths causes the action of the form to be replaced thus breaking the search functionality.

Proposed resolution

I propose that we remove the newly added facets_pretty_paths_form_views_exposed_form_alter function from the module file. If there is some functionality that is still required that will not have this adverse effect the community is welcome to improve the function and post patches here so that we can get a balanced solution. A patch will follow promptly in the comments.

Remaining tasks

Review the patch, possibly provide further improvements on the solution and testing by the community.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

roaldnel created an issue. See original summary.

roaldnel’s picture

Here is the patch for version 2.

johan den hollander’s picture

Assigned: roaldnel » Unassigned
Status: Active » Needs review

Rajeshreeputra made their first commit to this issue’s fork.

rajeshreeputra’s picture

Opened MR for easy review and merge.

joseph.olstad’s picture

looking into this now

joseph.olstad’s picture

This is a regression caused by

#3122188: Views exposed sort filters does not sort with facets

reverting 3122188

Thank you everyone above.

joseph.olstad’s picture

Status: Needs review » Fixed
joseph.olstad’s picture

Status: Fixed » Needs review
joseph.olstad’s picture

Status: Needs review » Fixed

release to follow shortly

joseph.olstad’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.