Problem/Motivation

Since updating to version 1.5 we found that the global search input action fields were being modified by facets pretty paths. The facets_pretty_paths_form_views_exposed_form_alter function in the module file seems to modify the action in this way which then causes the search functionality to not work except when the user is on the search results page.

Steps to reproduce

If you have a site with a global exposed form for search you should see that versions 1.5 and 2 of facets pretty paths causes the action of the form to be replaced thus breaking the search functionality.

Proposed resolution

I propose that we remove the newly added facets_pretty_paths_form_views_exposed_form_alter function from the module file. If there is some functionality that is still required that will not have this adverse effect the community is welcome to improve the function and post patches here so that we can get a balanced solution. A patch will follow promptly in the comments.

Remaining tasks

Review the patch, possibly provide further improvements on the solution and testing by the community.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

roaldnel created an issue. See original summary.

roaldnel’s picture

Here is the proposed patch.

flitt1’s picture

Hi, I've also run into this issue. It looks like the patch file is empty, could you try re-uploading it?

roaldnel’s picture

I noticed that now as well, here is a new upload.

roaldnel’s picture

flitt1’s picture

Confirmed that the patch in #4 resolves the issue for me.

roaldnel’s picture

Assigned: roaldnel » Unassigned
Status: Active » Needs review

Rajeshreeputra made their first commit to this issue’s fork.

chandu7929’s picture

Status: Needs review » Reviewed & tested by the community

Verified with patch #4, its working fine.

johan den hollander’s picture

The #9 MR is leaving a lot of code in place that has no further use.

joseph.olstad’s picture

Status: Reviewed & tested by the community » Fixed

#3122188: Views exposed sort filters does not sort with facets

reverted this to fix everyones issue here

sorry for the trouble, new release to follow shortly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.