Problem/Motivation
Since updating to version 1.5 we found that the global search input action fields were being modified by facets pretty paths. The facets_pretty_paths_form_views_exposed_form_alter function in the module file seems to modify the action in this way which then causes the search functionality to not work except when the user is on the search results page.
Steps to reproduce
If you have a site with a global exposed form for search you should see that versions 1.5 and 2 of facets pretty paths causes the action of the form to be replaced thus breaking the search functionality.
Proposed resolution
I propose that we remove the newly added facets_pretty_paths_form_views_exposed_form_alter function from the module file. If there is some functionality that is still required that will not have this adverse effect the community is welcome to improve the function and post patches here so that we can get a balanced solution. A patch will follow promptly in the comments.
Remaining tasks
Review the patch, possibly provide further improvements on the solution and testing by the community.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | form_actions_break_for_global_search_fields_1_5-3402421-4.patch | 1.79 KB | roaldnel |
| #2 | form_actions_break_for_global_search_fields_1_5-3402421-2.patch | 0 bytes | roaldnel |
Issue fork facets_pretty_paths-3402421
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
roaldnel commentedHere is the proposed patch.
Comment #3
flitt1 commentedHi, I've also run into this issue. It looks like the patch file is empty, could you try re-uploading it?
Comment #4
roaldnel commentedI noticed that now as well, here is a new upload.
Comment #5
roaldnel commentedComment #6
flitt1 commentedConfirmed that the patch in #4 resolves the issue for me.
Comment #7
roaldnel commentedComment #10
chandu7929 commentedVerified with patch #4, its working fine.
Comment #11
johan den hollander commentedThe #9 MR is leaving a lot of code in place that has no further use.
Comment #12
joseph.olstad#3122188: Views exposed sort filters does not sort with facets
reverted this to fix everyones issue here
sorry for the trouble, new release to follow shortly.