Problem/Motivation

Check-All and Uncheck-All Features Not Functioning in "Multiple Target" Language Selection on Sources Page on

Steps to reproduce

  • Go to the Source page
  • Select multiple as the language target
  • Click on Check-All and Uncheck-All
  • Observe the issue
CommentFileSizeAuthor
#4 Check-All-Features-Not-Functioning-in-Multiple-Target-Language-3401670-2.patch1.09 KBahmad khader
#2 Check-All-Features-Not-Functioning-in-Multiple-Target-Language-3401670-1.patch811 bytesahmad khader

Issue fork tmgmt-3401670

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ahmad Khader created an issue. See original summary.

ahmad khader’s picture

ahmad khader commented
StatusFileSize
new Check-All-Features-Not-Functioning-in-Multiple-Target-Language-3401670-1.patch811 bytes

Drupal Added js- to one of the selectors causing the check functionality not to work, The addition to that the code triggers multiple times due to the utility function once is missing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Ah, I guess claro renamed the form item classes (and so does gin I assume). Using the js prefixed classes makes sense, that's what they are for. Should we maybe also remove some of the extra classes like details-wrapper? I doubt that adds anything meaningful here, the tmgmt-source-checkout-wrapper should make this specific enough?

ahmad khader’s picture

ahmad khader commented
StatusFileSize
new Check-All-Features-Not-Functioning-in-Multiple-Target-Language-3401670-2.patch1.09 KB

yes, you are absolutely correct. We don't need this class, even on the targetLanguagesCheckboxesWrapper.

robbiehobby made their first commit to this issue’s fork.

robbiehobby opened merge request !96

bobooon’s picture

bobooon commented

MR includes the following fixes that are applicable to Claro and Gin:

  1. Previous patch to fix the check/uncheck control
  2. Fixed check/uncheck visibility when "Multiple" is not selected
  3. Fixed position of color legend (for gin)
james.williams’s picture

james.williams
Location Coventry, UK
commented

2. Fixed check/uncheck visibility when "Multiple" is not selected

I was looking for that bit, thank you!

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, adding to the merge train.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • berdir committed 36cb1b6c on 8.x-1.x authored by bobooon 
    fix: #3401670 Fixes Check-All and Uncheck-All Features Not Functioning...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.