Problem/Motivation

Core config validation is getting stricter. in 10.2, type: email is now validated and fails tests.

Webform uses that, but those keys can contain lots of things that are not actually e-mails, including tokens, _default and so on.

Steps to reproduce

Proposed resolution

Change to type: string.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork webform-3400868

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Berdir created an issue. See original summary.

Berdir opened merge request !379

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review

Opened a merge request.

Pipeline with 6.2.x against 10.2.x, everything is failing: https://git.drupalcode.org/issue/webform-3400868/-/jobs/309374

Pipeline with the MR against 10.2.x: not everything is failing: https://git.drupalcode.org/issue/webform-3400868/-/jobs/309454

I expect there might still be some problems, due to the changed field UI for example.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Reviewed & tested by the community

Yep this makes sense

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Note that this doesn't update all of these tests forms, there are _dozens_, and still 150+ test fails.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: to_email and similar config keys have schema type email but allow other things » [PP-2] to_email and similar config keys have schema type email but allow other things
Status: Reviewed & tested by the community » Needs work
Issue tags: +Configuration schema, +validation
Related issues: +#3402168: Follow-up for #3361534: Config validation errors can still occur for contrib modules, disrupting contrib, +#3402134: Test Webform against upcoming 10.2.x on GitLab CI — and use concurrency to make tests 6x faster (on GitLab CI)

there are _dozens_, and still 150+ test fails.

😬

Let's make it easy to see those: #3402134: Test Webform against upcoming 10.2.x on GitLab CI — and use concurrency to make tests 6x faster (on GitLab CI). The only way that we can be confident that this issue makes all tests pass is if this issue can make those tests green. So … shouldn't this instead wait for that MR to land first? 🤔

Other observations:

  1. TESTS SHOULD NEVER HAVE FAILED in the first place. Investigated and … opened a new core critical issue, with a root cause analysis here: #3402168-7: Follow-up for #3361534: Config validation errors can still occur for contrib modules, disrupting contrib.
  2. That being said, it looks like the config schema of webform is rather inaccurate, and fixing those inaccuracies is likely to help make the module more stable. It's also likely to result in a better experience for the Config Translation module, for example.
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

As of #3402168-17: Follow-up for #3361534: Config validation errors can still occur for contrib modules, disrupting contrib, #3402134: Test Webform against upcoming 10.2.x on GitLab CI — and use concurrency to make tests 6x faster (on GitLab CI) is passing all of the 10.2.x tests 👍

With the exception of unrelated failures (for example, WebformStatesHiddenTest and WebformSettingsPreviewTest fail because it's asserting markup literally instead of using CSS selectors, XPath or DOMDocument — probably these output changes are due to #2441811: Upgrade filter system to HTML5). See the results.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Closed (duplicate)

I am pretty sure this was addressed via #3409978: Configuration validation fails for email fields with token values