Problem/Motivation
When adding multiple button attributes, the attribute values have a trailing space like this:
my-attribute="value "
This only happens if there is more than one attribute.
Also I was only noticing this on the production server not on my local development server, using the exact same views config. So Im guessing it has to do with the way my two environments handle line breaks.
Proposed resolution
add a trim() around the attribute value when rendering the button.
I will provide a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | views-add-button--trim-button-attribute-value--15298432--2.patch | 1.14 KB | loze |
Issue fork views_add_button-3398151
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
loze commentedComment #3
loze commentedComment #4
loze commentedComment #5
loze commentedComment #7
laboratory.mikeLooks good, I'll check it out and get it merged after QA.
Comment #8
terry_kolodiy commentedThe patch works fine. The problem is gone. I think it can be merged
Comment #11
terry_kolodiy commented