Problem/Motivation

See #3396149: Drupal 9 users being updated to 3.0.0-beta1 incorrectly - D10 sites must upgrade to csv_serialization 4.x

CommentFileSizeAuthor
#7 views_data_export-change_csv_serialization_version-3397869-0.patch374 bytesj.b

Issue fork views_data_export-3397869

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !30

acbramley’s picture

acbramley commented
Status: Active » Needs review
elc’s picture

elc commented

This may not be as simple as allowing the extra version - csv_serialization is 3.x branch for D9, and 4.x branch for D10.

Is there a way for this to be specified in composer.json format, or should csv_serialization also be split into two branches?

The require effectively needs to be: (drupal/core:^9, drupal/csv_serialization:^3) || (drupal/core:^10, drupal/csv_serialization:^4) which I don't believe is possible at present.

Another possibility would be hook_requirements informing of the correct version to install.

acbramley’s picture

acbramley commented

@ELC composer dependency resolution solves that for us. It won't update to 4.x unless the site is also on D10.

j.b’s picture

j.b commented

Hello,
Can't we have a patch to correct the version in the composer.json while waiting for the merge request to be approved ?

j.b’s picture

j.b commented
StatusFileSize
new views_data_export-change_csv_serialization_version-3397869-0.patch374 bytes

I made the patch for those who can't wait

nagender16’s picture

nagender16 commented

The patch in #7 working for me

j.b’s picture

j.b commented

just add this to your project composer.json

        "drupal/csv_serialization": "4.0 as 3.0",
        "drupal/views_data_export": "^1.3",

then composer update

markdorison’s picture

markdorison
he/him
commented
Status: Needs review » Reviewed & tested by the community

#7 looks good to me.

stijnstroobants’s picture

stijnstroobants
Primary language Dutch
Location Leuven
commented

+1 RTBC for #7

brooke_heaton’s picture

brooke_heaton commented

The tip in #9 helped me get this working in composer.json. Thanks @j.b.

solideogloria’s picture

solideogloria commented

A patch won't work if applied via Composer, since the composer.json is read prior to patching.

Can we get this committed, please?

solideogloria’s picture

solideogloria commented
Priority: Normal » Critical

jhedstrom made their first commit to this issue’s fork.

  • jhedstrom committed 46392e36 on 8.x-1.x authored by acbramley 
    Issue #3397869 by acbramley, j.b, solideogloria, ELC, nagender16,...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

acbramley’s picture

acbramley commented

Thanks @jhedstrom! Comparing 8.x-1.x to 8.x-1.3, this is the only change so a release would be amazing if possible!

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

Done!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.