Problem/Motivation

For example this pipeline has failed https://git.drupalcode.org/issue/migrate_tools-3104268/-/pipelines/36788 with 

Unable to create pipeline
Project `drupalspoons/composer-plugin` not found or access denied! Make sure any includes in the pipeline configuration are correctly defined.

Steps to reproduce

Create a merge request on any issue

Proposed resolution

Update to the default gitlab-ci.yml

Issue fork migrate_tools-3396130

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !48

scott_euser’s picture

scott_euser commented
Assigned: scott_euser » Unassigned
Status: Active » Needs review

heddn made their first commit to this issue’s fork.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Category: Bug report » Task
Status: Needs review » Needs work

Tests run differently on legacy test bots and gitlab. We'll need to fix that before we can merge this.

thakurnishant_06 made their first commit to this issue’s fork.

lostcarpark made their first commit to this issue’s fork.

lostcarpark’s picture

lostcarpark commented

The tests were mostly failing on the [error], [warning] and [notice] labels, which seem to have color coding codes in the output. I simply took those labels out of the checks, and left to match on the rest of the output.
There were also some assertStringNotContainsString checks against "4", that were failing. I'm guessing that was matching against something in the color coding. I expanded those checks to check the output does not contain "Processed 4 items"

lostcarpark’s picture

lostcarpark commented

I've added variables to the .gitlab-ci.yml to enable additional tests:

  • MAX_PHP (tests against PHP 8.3)
  • PREVIOUS_MAJOR (tests against D9)
  • PREVIOUS_MINOR (currently tests against 10.0)
  • NEXT_MINOR (currently tests against 10.2)
  • NEXT_MAJOR (tests against D11)

Currently NEXT_MAJOR is failing, but as it is only considered a warning, I suggest leaving it in. Since the .info.yml file for the module contains core_version_requirement: '>=9.1', it makes sense to test against the D11 and fix issues it discovers. If I can figure out the reason before this gets merged, I'll try to fix. If not, I suggest opening a separate issue for D11 compatibility.

I'd also suggest not trying to fix code quality issues under this issue, but instead open separate issues after this merges.

lostcarpark’s picture

lostcarpark commented
Status: Needs work » Needs review
lostcarpark’s picture

lostcarpark commented

It turns out that specifying:

core_version_requirement: '>=9.1'

Is not a good idea when using OPT_IN_TEST_NEXT_MAJOR.

It runs the following:

grep -q "\^11" *.info.yml || (grep -q "\^10" *.info.yml && sed -i "s/\^10/\^10 \|\| ^11/" *.info.yml)

This checks if ^11 is in the .info.yml file. If it isn't, it will attempt to replace ^10 with ^11. If neither succeeds, it aborts the NEXT_MAJOR test.

I've updated the .info.yml file to:

core_version_requirement: '^9.1 || ^10 || ^11'

All tests are now passing.

There are still code quality issues, but I suggest looking at those in separate issues.

lostcarpark’s picture

lostcarpark commented

I have put back the [notice] and [warning] tags in the error checks using regular expressions to skip any color codes. Also combined some of the "1/4" type checks into the same regular expressions.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

Thank you for your effort to get this over the finish line. Much appreciated.

  • heddn committed 0485cb8c on 6.0.x authored by scott_euser 
    Issue #3396130 by lostcarpark, scott_euser, heddn: Switch GitLab CI...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.