Test l10n groups implementation

Eric, can you test again? I pushed new permissions, so that group admins no longer can delete their own group (but global admins will be able to delete groups even when they are not members).

@ericdsd thanks! Could you please review #3437137: Translation suggestion creation and moderation don't provide group permission first, and perhaps amend your report, as I fear there might be interferences between both issues?

For the record, you will need to configure group permissions at /admin/group/types/manage/translation/permissions#module-l10n_groups (since the MR is not merged yet, I cannot provide the corresponding configuration, which is stored in another repo).

NOTE: a group member doesn't have a link to leave a group is it normal ?

No, it is not. I created #3547963: Incomplete block.

Any authentificated user has import tab avalilable on all groups (even when not in this group) bu the import trigger the following error
The website encountered an unexpected error. Try again later.

TypeError: Drupal\file\Upload\FileUploadHandler::handleExtensionValidation(): Return value must be of type string, null returned in Drupal\file\Upload\FileUploadHandler->handleExtensionValidation() (line 431 of core/modules/file/src/Upload/FileUploadHandler.php).
Drupal\file\Upload\FileUploadHandler->handleFileUpload(Object, Array, 'temporary://', Object, ) (Line: 660)
file_save_upload('file', Array, 'temporary://', 0) (Line: 143)
Drupal\l10n_community\Form\ImportForm->submitForm(Array, Object)

We are currently investigating on this one.

Member

Note : The user is automatically accepted in group hence he can create group stories right after join), i think stories creation might be limited either by an higher group role or by a people role eg. confirmed (i guess we could eventually rely on community validation as it’s used on drupal.org to confirm. people are not spammers).

This is how it is currently configured. Now, how relevant this is, we may wonder.

Test permissions in my group:

add story > yes OK

Can create stories in his groups but cannot edit or delete those is it normal ?

I added the edit permission, but deletion is currently not allowed, maybe for good reason.

Translation community moderator

Test permissions in my group:

add story > yes OK


make suggestions > yes
 OK

moderate suggestion > yes OK


self moderate > no OK ?

Can create stories in his groups but cannot edit or delete those is it normal ?

Now they should be able to edit stories (but not to delete them).

Translation community manager

Test permissions in my group:

add story > yes OK


make suggestions > yes OK


moderate suggestion> no KO


self moderate > no KO


Maybe it's ok not to allow moderation and is intended to be used alonside with Translation community moderator when needed (which would make sense imho), can you confirm ?

You are right, this is the job of the translation community moderator.

Admin

Test permissions in my group:

add story > yes OK


make suggestions > yes OK


moderate suggestion > no KO ?


self moderate > no KO ?

I have just added this permission.

Any authentificated user has import tab avalilable on all groups (even when not in this group)

This should now be fixed.

the import trigger the following error
The website encountered an unexpected error. Try again later.

TypeError: Drupal\file\Upload\FileUploadHandler::handleExtensionValidation(): Return value must be of type string, null returned in Drupal\file\Upload\FileUploadHandler->handleExtensionValidation() (line 431 of core/modules/file/src/Upload/FileUploadHandler.php).
Drupal\file\Upload\FileUploadHandler->handleFileUpload(Object, Array, 'temporary://', Object, ) (Line: 660)
file_save_upload('file', Array, 'temporary://', 0) (Line: 143)
Drupal\l10n_community\Form\ImportForm->submitForm(Array, Object)

So should this one (related to #3403253: Simplify how 'allow all extensions' file upload validation works). We now only allow .po file, I hope this is not too restrictive.

I performed the test on the 3.0.x development branch, and those are the results:

Anonymous member

Add story NO
Make suggestions NO
Moderate suggestions NO
Self Moderate NO

Outsider

Add story NO
Make suggestions NO
Moderate suggestions NO
Self Moderate NO

Group Member

Permissions in my group

Add Story YES
Make suggestions YES
Moderate suggestions NO
Self Moderate NO

Permissions in another group

Add Story NO
Make suggestions NO
Moderate suggestions NO
Self Moderate NO

Translation self-moderator

Permissions in my group

Add Story YES
Make suggestions YES
Moderate suggestions NO
Self moderate YES

Permissions in another group

Add Story NO
Make suggestions NO
Moderate suggestions NO
Self moderate NO

Translation community moderator

Permissions in my group

Add Story YES
Make suggestions YES
Moderate suggestions YES
Self moderate NO

Permissions in another group

Add Story NO
Make suggestions NO
Moderate suggestions NO
Self moderate NO

Translation community manager

Permissions in my group

Add Story YES
Make suggestions YES
Moderate suggestions NO
Self moderate NO

Permissions in another group

Add Story NO
Make suggestions NO
Moderate suggestions NO
Self moderate NO

Admin

Permissions in my group

Add Story YES
Make suggestions YES
Moderate suggestions YES
Self moderate YES

Permissions in another group

Add Story NO
Make suggestions NO
Moderate suggestions NO
Self moderate NO

Thanks for the recap!