It would be useful to subclass MigrateBatchExecutable in some cases to customize how the batch process is created and executed (for example, overriding MigrateBatchExecutable::calculateBatchLimit).
The class currently has two static references to itself that prevent it from being subclassed/overridden. Changing these to late static bindings improves the extensibility of this class.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3391697-2.patch | 909 bytes | mediabounds |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !51
Comments
Comment #2
mediabounds commentedComment #3
el7cosmosWithout this, it's imposibble to override methods without duplicating
batchProcessImport, because the methods won't be called.This patch fixed the issue.
Comment #5
el7cosmosThere is another one in
batchImport, create and MR with additional changeComment #6
larowlanLooks good to me
The failing test is present in HEAD - https://www.drupal.org/pift-ci-job/2820117
Comment #8
heddnThanks for this improvement