Problem/Motivation

There are several issues fixed now RTBC and some of them merged. For the most part, I've seen issues being tested on Drupal 9.5 and Drupal 10 (this is also what the gitlabCI is set up to test on). This means that when everything gets merged there is a potential that the module might break for D9.2, D9.3, and D9.4, meaning it might be a good time for a new module version.

But before that is done when the issues get merged it would be good to test with the above-mentioned Drupal versions just to check if there is even a need for it.

Issues:

Done:
#3315952: Replace README.txt with README.md
#3549207: Place Automated Logout under "Security" on the module page
#3574127: Fix the issues reported by cspell
#3308456: Autologout cookie is not secure
#3565274: Typehint SessionManager using its interface
#3469056: Exception thrown when session doesn't exist
#3498529: Add JS file only when user is authenticated
#3367062: Logout Message not rendering markup
#3339695: Use Drupal.dialog call instead of jQuery dialog
#3557620: Remove JS Cookie dependency
#3324738: Drush login is blocked first time your try to login after an autologout
#3390606: Make Drupal 10 warning message more user friendly
#3390475: Admin form has non gender neutral help text
#3378238: Does Automated logout support CKEditor5?
#3195164: Option to disable destination
#3358284: js error: Cannot read properties of null (reading time)
#3372010: Warning: Undefined array key 1 in Drupal\autologout\EventSubscriber\AutologoutSubscriber->onRequest()
#3310136: Create ability to hook into the user logout
#3307938: Undetected request prevents logout
#3388601: Use GitLab CI for testing
#3214958: Autologout triggered in background tab, no indication in other open tabs
#3348394: Automated logout functionality not working, due to ajaxing property return true and ajaxStop event not triggering even though ajax req completed.
#3301945: getRemainingTime treats logout_regardless_of_activity as always active

Postponed until next release or closing as fixed after retesting when the above is released:
#3243264: Add documentation about disabling autologout
#3390135: Drupal 10 second dialog logout
#3469258: Multiple dialogs open / have to click multiple times

Comments

admirlju created an issue. See original summary.

admirlju’s picture

Issue summary: View changes
admirlju’s picture

admirlju’s picture

Also if I forgot some issue or people find something that really needs to be fixed before a new release, please add it to the list.

deaom’s picture

Issue summary: View changes
jonraedeke’s picture

Thanks for your work on this module. Any movement toward a new release? It's getting tough to track the various patches.

dan.d’s picture

Issue summary: View changes
dan.d’s picture

As I worked through the fix for #3469258: Multiple dialogs open / have to click multiple times, I've come to realize that at times it's hard to guess the reason for certain decisions that were made by developers who contributed to the module. Consequently, making changes and testing the whole set of features turned out to be quite cumbersome.

I would like to suggest that we create a doc page dedicated to describing the settings and the expected behavior prior to working on a new release. Whoever works on the code must also try to provide comments and code annotations.

It is a seemingly simple module. However, it deals with security and therefore must be well organized and implemented, IMO.

japerry’s picture

Version: 8.x-1.x-dev » 2.x-dev

Moving to 2.x -- while 8.x-1.x releases will still get made (since the branches are exactly the same), there won't be any development on the 8.x-1.x branch anymore.

asrob’s picture

Do you plan to release a new version?

the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
japerry’s picture

2.x adoption is looking pretty good! Since the commits haven't made any significant changes, probably roll one more 8.x-1.x release to fix the D10 issue and then drop 9.5 support as 2.0 prepares for D12

the_g_bomb’s picture

Sounds good, thanks

the_g_bomb’s picture

Issue summary: View changes
inregards2pluto’s picture

I'm working through some of the outstanding issues to re-test fixes post merging in https://www.drupal.org/project/autologout/issues/3339695 so that we can hopefully maintain momentum in merging things in.

I do have a question regarding the current failing phpunit tests on 2.x. As far as I can tell, the issues are related to a couple of files that were migrated in from D6/D7.

I don't have any context on if/why the `/migrate` directory is still needed if we updated the version requirement for 2.x to be for ^9.2 || ^10 || ^11.

Could we safely remove these files for 2.x? Or is some part of the module hooking into those? I don't have a ton of experience with the migration process yet, so I'm not sure how these work within the current module.

the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Issue summary: View changes
the_g_bomb’s picture

Thanks, everyone, for the help getting these over the line.
I'll prepare to release:
2.0.2 & 8.x-1.7

ressa’s picture

Sounds fantastic, thanks everyone for methodically working through the epic list of +20 issues to make this happen!

the_g_bomb’s picture

Status: Active » Fixed

Released

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.