Views exposed filter warnings on Date filter min & max

Thank for reporting.

We will need a test to show this issue, but also may need to dig deeper. Typically these kind of issues putting an isset or !empty is masking an actual problem.

I think adding those empty() calls is enough here, since the same check is being done in the child method Drupal\views\Plugin\views\filter\Date::acceptExposedInput():

if ($operators[$operator]['values'] == 1) {
  // When the operator is either <, <=, =, !=, >=, > or regular_expression
  // the input contains only one value.
  if ($this->value['value'] == '') {
    return FALSE;
  }
}
elseif ($operators[$operator]['values'] == 2) {
  // When the operator is either between or not between the input contains
  // two values.
  if (empty($this->value['min']) || empty($this->value['max'])) {
    return FALSE;
  }
}

Updated issue summary as per issue summary document.

Run the PHPUnit locally, Not getting any errors. But getting errors in the git pipeline.

Previously tagged for tests so moving back for those

Did not review.

Added empty condition for date filter and test for MIN and MAX empty on date filter.

Believe the tests need some work as the test-only feature is passing when it should fail.

Test-only is still passing when it should be failing.

@smustgrave
Verified the Failing jobs are irrelated to the changes. After syncing the latest 11.x branch the issue was resolved.

I have investigated this test case and observed that the warning appears only under specific conditions. Initially, when we add a date as an exposed filter and select the 'Between' operator, the warning does not appear upon saving the view. However, if we edit the date exposed filter, switch from 'single filter' to 'group filters,' and again select the 'Between' operator for the group filters, saving the view triggers the warning. When we access the view page and select the 'All' option, the warning arises because the single filter operator is still set to 'Between,' but the 'min' and 'max' values are not available for the 'All' option.

To demonstrate this behaviour, I modified the test case to show the warning. After applying the solution, the test case passes successfully. Please review and let me know .

@shalini_jha It seems the pipeline issue was random. After rerunning it, it was resolved. I also verified the file; it was irrelevant to the change made.

2 nitpick comments.

i have addressed the feedback. and updated the MR , it seems again pipeline fail with not related to this changes.

I have re running the pipeline and now it is fixed. so moving this for NR. Kindly review.

This issue also happens when you use values for date fields instead of the range option (min/max), but when doing that, it throws the warning on the key 'value':

Warning: Undefined array key "value" in Drupal\views\Plugin\views\filter\NumericFilter->acceptExposedInput() (line 448 of core/modules/views/src/Plugin/views/filter/NumericFilter.php).

I am adding a patch because I do not want to commit the changes to the MR since it is already under review. However, I believe it makes sense to address that as part of this issue. In that case, we would probably need to update the issue's title to be more precise.

#34 I think should be created as a child issue. There is still considerable work required to complete this issue in itself.

The test-only feature is now working correctly.

Removing the Needs tests tag.

Rebased MR. Pipeline tests are green.

Needs before and after screenshots

Thank you for your review. Since this issue is related to the warning and the test already displays the warning message without any UI changes, is it still necessary to include a screenshot for this?

Okay I will remove it. I have not reproduced the issue yet. So long as it can be reproduced using the steps it should be okay.

Believe feedback has been addressed.

Not super liking having to do all the manual changes vs having a view already setup but seems to be how it's already setup.

Tests are still showing coverage https://git.drupalcode.org/issue/drupal-3389478/-/jobs/3697086

Replicated this is fixed manually following steps in summary, so LGTM.

I think this should use a strict comparison so that it handles '0' correctly.

The PR from #3294700: Date filter shows error in view exposed group filter with multiple select option contains almost the same solution, but already handles the strict comparison.
I propose to use the fix from #3294700: Date filter shows error in view exposed group filter with multiple select option and close this issue.