I am getting this warnings:

Warning: Undefined array key "url" in Drupal\Core\Asset\JsCollectionOptimizerLazy->optimizeGroup() (line 174 of core/lib/Drupal/Core/Asset/JsCollectionOptimizerLazy.php).
Drupal\Core\Asset\JsCollectionOptimizerLazy->optimizeGroup(Array) (Line: 183)
Drupal\system\Controller\AssetControllerBase->deliver(Object, 'js_65779hE6r_dFZDJc2ptSqee0DGm5DCe-KQ8lpAEa8ks.js')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 182)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

seems there is a license URL missing in
views_slideshow.libraries.yml

for me inserting an URL there, fixes the warnings

CommentFileSizeAuthor
#12 3387913-12-views_slideshow.patch474 bytesosopolar

Issue fork views_slideshow-3387913

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nojj created an issue. See original summary.

keshavv’s picture

keshavv commented

@nojj Which URL did you use?
There is no LICENCE file present on the git for the library.

nojj’s picture

nojj commented

I just added a MIT license URL for testing:

license:
     name: MIT
     url: https://opensource.org/license/mit/
     gpl-compatible: true

Shreya_th made their first commit to this issue’s fork.

Shreya_th opened merge request !8

shreya_th’s picture

shreya_th commented

@aaron ,
I have added license url in views_slideshow.libraries.yml and also created MR for this issue . Kindly review the changes.

floydm made their first commit to this issue’s fork.

floydm’s picture

floydm commented

In the commit from comment #5 was an extra space before the key "url" being added that caused the yml parser to fail with the following error:

Drupal\Core\Asset\Exception\InvalidLibraryFileException: Invalid library definition in modules/contrib/views_slideshow/views_slideshow.libraries.yml: A colon cannot be used in an unquoted mapping value at line 33 (near " url: https://opensource.org/licenses/MIT"). in Drupal\Core\Asset\LibraryDiscoveryParser->parseLibraryInfo() (line 367 of core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php).

I've updated the branch associated with MR !8 to remove the extra space.

floydm’s picture

floydm commented
Status: Active » Needs review

Switching to "Needs Review"

nojj’s picture

nojj commented

Works for me. Thank you!

firfin’s picture

firfin commented
Status: Needs review » Reviewed & tested by the community

Used this link with composer-patches and seems to solve the problem.
This approach is also the recommended way to solve this according to core issue #3359497: Log an error message when library definitions have a license with no URL defined

Use of the MIT license seems a correct assumption also (from https://github.com/briancherne/jquery-hoverIntent/blob/master/jquery.hov... ) :

* You may use hoverIntent under the terms of the MIT license. Basically that
* means you are free to use hoverIntent as long as this header is left intact.
* Copyright 2007-2019 Brian Cherne

Don't think we need tests for this, but might be wrong. Marking this RTBC anyway.

Link used for patch:
https://git.drupalcode.org/project/views_slideshow/-/merge_requests/8.diff

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
StatusFileSize
new 3387913-12-views_slideshow.patch474 bytes

Copy of patch from https://git.drupalcode.org/project/views_slideshow/-/merge_requests/8.diff attached, to be used with composer, see "Patches from drupal.org merge request URLs are dangerous?".

gogowitsch’s picture

gogowitsch commented

+1: I have reviewed and tested the patch. 👍

I have opened a PR here: https://github.com/briancherne/jquery-hoverIntent/pull/86

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Confirming RTBC

gogowitsch’s picture

gogowitsch commented

The GitHub PR from #13 has been merged, further confirming the MIT license.

nickdickinsonwilde made their first commit to this issue’s fork.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented

Thanks y'all

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.