Problem/Motivation

Drupal\pagedesigner\Plugin\DataType\PagedesignerData::getContent() raise an error if no root element match the provided $root_id

Steps to reproduce

Proposed resolution

Encapsulate the function in an if $root != NULL (see fork)

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork pagedesigner-3387243

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

GuillaumePacilly created an issue. See original summary.

GuillaumePacilly opened merge request !75

pvbergen’s picture

pvbergen commented
Status: Active » Reviewed & tested by the community
pvbergen’s picture

pvbergen commented
Status: Reviewed & tested by the community » Needs work

I would propose to set $this->processes to an empty string in this case. This would represent an empty output, returning null upstream might cause other problems.

pvbergen’s picture

pvbergen commented
Status: Needs work » Needs review
pvbergen’s picture

pvbergen commented
Status: Needs review » Reviewed & tested by the community

pvbergen’s picture

pvbergen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.