Hi,

When you place a mail.css file in your theme base directory, then Mimemail includes that instead of all the CSS files of your default theme. A handy feature to keep your emails clean and small.

When using the Zen theme however, things go wrong when you are used to place all your custom stuff in a Zen subtheme (like your should). Mimemail doens't look for a mail.css file in your Zen subtheme, it will only catch it if you place it in your base Zen theme directory.

I'm suggesting the following patch to have Mimemail's use of themes play nicer with the Zen theme. I know this is kind of a corner case and this patch isn't useful for a lot of people (not everyone uses the Zen theme). But it doesn't hurt for them and it will solve a lot of head aches for the unexperienced Zen/Mimemail/Drupal user.

When looking for a mail.css file, Mimemail now first looks in the Zen subtheme (if available), then in the normal (Zen base) theme. Nothing changes for non-Zen users, things get a lot better for those who do use Zen :)

So, include it if you like, otherwise: no hard feelings :)

Hopla

Files: 

Comments

Brico’s picture

The same thing happens with the blueprint theme. mail.css has to be in the root whereas it should be in the css folder.

cheers

Brico’s picture

Category:feature» support
Brico’s picture

Version:5.x-1.0» 6.x-1.0-alpha1
Brico’s picture

It's actually version 6.x-1.2 that this applies to...

arski’s picture

any chance of getting this fixed? cheers

Simon Georges’s picture

Version:6.x-1.0-alpha1» 6.x-1.x-dev
Category:support» feature
Status:Needs review» Needs work

The function is now a preprocess function and is located in theme/mimemail.theme.inc file, so the patch needs a little work before being integrated. The code itself looks good.

mpaler’s picture

For what it's worth, mail.css works with Zen subthemes if you put it directly within the subtheme directory, rather than within the subtheme/css/ directory.

sgabe’s picture

Status:Needs work» Needs review
StatusFileSize
new509 bytes

This seems to be enough, see the attached patch.

sgabe’s picture

Status:Needs review» Fixed

Committed to the development snapshot.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.