[1.0.x] Translations connector

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml translations_connector/

FILE: translations_connector/src/Form/TranslationsConnector.php
--------------------------------------------------------------------------------
FOUND 34 ERRORS AND 2 WARNINGS AFFECTING 36 LINES
--------------------------------------------------------------------------------
   7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
  15 | ERROR   | [x] Missing class doc comment
  17 | ERROR   | [x] Missing function doc comment
  21 | ERROR   | [ ] Missing short description in doc comment
  26 | ERROR   | [ ] Missing short description in doc comment
  31 | ERROR   | [ ] Missing short description in doc comment
  36 | ERROR   | [ ] Missing short description in doc comment
  41 | ERROR   | [ ] Missing short description in doc comment
  46 | ERROR   | [ ] Missing short description in doc comment
  51 | ERROR   | [ ] Parameter $entit_type_manager is not described in comment
  54 | ERROR   | [ ] Doc comment for parameter $entityTypeManager does not match actual variable name $route_match
  55 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  57 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  59 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  61 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  63 | ERROR   | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
  64 | ERROR   | [ ] Missing parameter comment
  89 | ERROR   | [x] Missing function doc comment
  91 | ERROR   | [x] Inline comments must start with a capital letter
  95 | ERROR   | [x] Inline comments must start with a capital letter
 114 | ERROR   | [x] Inline comments must start with a capital letter
 130 | ERROR   | [x] Missing function doc comment
 143 | ERROR   | [x] Inline comments must start with a capital letter
 145 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use "" quotes instead
 160 | ERROR   | [x] Missing function doc comment
 161 | ERROR   | [x] Inline comments must start with a capital letter
 164 | ERROR   | [x] Inline comments must start with a capital letter
 167 | ERROR   | [x] Inline comments must start with a capital letter
 171 | ERROR   | [x] Inline comments must start with a capital letter
 174 | ERROR   | [x] Inline comments must start with a capital letter
 177 | ERROR   | [x] Inline comments must start with a capital letter
 183 | ERROR   | [x] Inline comments must start with a capital letter
 184 | WARNING | [ ] Unused variable $source_alias.
 199 | ERROR   | [x] Inline comments must start with a capital letter
 201 | ERROR   | [x] Inline comments must start with a capital letter
 204 | ERROR   | [x] Inline comments must start with a capital letter
--------------------------------------------------------------------------------

2. FILE: translations_connector.info.yml

package: Custom

Modules should avoid using that value for the package.

Rest looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

No issues found
Changing status to RTBC!

It is not clear what the purpose of the module is, since Drupal core already allows to create translations for existing nodes.
The project page needs to make that clearer, and to make clear why this module is required over what Drupal core already provides.

    // Set a status message.
    $this->messenger->addMessage($translation->getTitle() . '/' . strtoupper($values['target_language']) . ' has been added as a translation of ' . $node->getTitle() . '/' . strtoupper($node->langcode->value) . '.');

The first parameter of addMessage() must be a translatable string, not a concatenation of dynamic strings.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.