Problem/Motivation

When looking at #3306855: Admin menu-link Domain redirects missing, I noticed that the module uses Settings for the main redirect settings page. Other modules often put the name of the module with "settings" so it's more clear what it's for, e.g. Devel settings and Media settings.

Steps to reproduce

Proposed resolution

Update Settings in all places to Redirect settings:

redirect.links.menu.yml:  title: 'Settings'
redirect.links.task.yml:  title: Settings
redirect.module:      $output .= '<dd>' . t('The <a href=":settings">"Settings"</a> page presents you with a number of means to adjust redirect settings.', [':settings' => Url::fromRoute('redirect.settings')->toString()]) . '</dd>';
redirect.routing.yml:    _title: 'Settings'

Remaining tasks

  1. Update code
  2. Review and test
  3. Commit :)

User interface changes

User will see Redirect settings.

API changes

Data model changes

CommentFileSizeAuthor
#10 redirect-after-patch-issue-3382165.png101.5 KBcleavinjosh
#10 redirect-before-patch-issue-3382165.png97.76 KBcleavinjosh
#5 After_Patch_Redirect_Issue #3382165.png38.38 KBrushikesh raval
#5 Before_Patch_Redirect_Issue #3382165.png36.79 KBrushikesh raval

Issue fork redirect-3382165

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kristen Pol created an issue. See original summary.

keshavv made their first commit to this issue’s fork.

keshavv opened merge request !54

keshavv’s picture

keshavv commented
Status: Active » Needs review

@kristen-pol, As per your suggestion. I have created the MR.
Kindly review.

rushikesh raval’s picture

rushikesh raval commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before_Patch_Redirect_Issue #3382165.png36.79 KB
new After_Patch_Redirect_Issue #3382165.png38.38 KB

I have applied patch from MR!54 & Tested. Required changes are done.

RTBC +1

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

Most such settings page titles, including the mentioned examples use a lowercase settings then, which I think this should as well.

samit.310@gmail.com opened merge request !94

samit.310@gmail.com changed the visibility of the branch 3382165-rename-settings-to to hidden.

samitk’s picture

samitk commented
Status: Needs work » Needs review

Hi @Berdir,

I fixed it, Please review.

Thanks
Samit K.

cleavinjosh’s picture

cleavinjosh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new redirect-before-patch-issue-3382165.png97.76 KB
new redirect-after-patch-issue-3382165.png101.5 KB

Hi @samit.310@gmail.com,

I applied MR!94, it was applied smoothly and addressed the concern on comment #6.

➜  redirect git:(8df775a) curl https://git.drupalcode.org/project/redirect/-/merge_requests/94.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2631    0  2631    0     0   5437      0 --:--:-- --:--:-- --:--:--  5435
patching file redirect.links.menu.yml
patching file redirect.links.task.yml
patching file redirect.module
patching file redirect.routing.yml
➜  redirect git:(8df775a) ✗

Thank you.