Problem/Motivation

In the issue #3351776 the 'args' varchar length was increased to 1024 in an update hook, but not in the schema. Consequently, users who do a new install will not get the 1024 varchar length. Credit to @asherry for spotting the problem and creating a patch in the closed (fixed) issue.

CommentFileSizeAuthor
#8 increase-args-length-3381746-1.patch1.61 KBbmunslow

Issue fork draggableviews-3381746

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisck created an issue. See original summary.

chrisck opened merge request !25

pnavarrr’s picture

pnavarrr commented

Using Drupal 10.1.5 and module version 2.1.3. The patch created on the issue #3351776 it's working for me.

lluvigne made their first commit to this issue’s fork.

lluvigne’s picture

lluvigne
Primary language Spanish
Location Seville, Spain
commented
Status: Active » Needs review
Issue tags: +ContributionWeekend2024

Tested with Drupal 10 and release 2.1.3 and works well.

Since update hook on 3351776 was included in the latest stable release, we need to add a new hook update to repeat the same process as before, to update installations that could happened in this time interval. I added a new hook to MR that execute the update number 8105 (I did it that way to keep trace of the original update and issue where that update was created).

For me, change in schema works great. Just this update needs to be reviewed.

jlbellido’s picture

jlbellido
Primary language Spanish
commented

I've reviewed the changes introduced on the MR and they are fine for me.

I'm moving it RTBC

jlbellido’s picture

jlbellido
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community
bmunslow’s picture

bmunslow commented
StatusFileSize
new increase-args-length-3381746-1.patch1.61 KB

Uploading patch file based on MR 25

  • istryker committed 28555bf4 on 2.1.x 
    Issue #3381746 by chrisck: Increase 'args' varchar length in schema to...
istryker’s picture

istryker commented
Status: Reviewed & tested by the community » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.