Problem/Motivation

The varchar length of 255 for the 'args' array is insufficient when dealing with lengthy arguments in a views query. Some queries can create long arguments (e.g. list of taxonomy term IDs) and as such, a warning message is shown when trying to save the row order.

There was an error while saving the data. Please, try again.

After that, the draggableviews order is unable to save.

Steps to reproduce

  • Install draggableviews
  • Create a view table with rows
  • Filter the rows with an exposed or contextual filter with a long argument list
  • Try to reorder the rows with drag handles
  • Save order

Proposed resolution

Increase length of varchar for the 'args' array to a higher value than 255.

CommentFileSizeAuthor
#6 fix-install.patch451 bytesasherry

Issue fork draggableviews-3351776

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chrisck created an issue. See original summary.

chrisck opened merge request !21

podarok made their first commit to this issue’s fork.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 2.1.x-dev » 2.1.3
Status: Active » Fixed

tnx

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

asherry’s picture

asherry commented
StatusFileSize
new fix-install.patch451 bytes

I ran into some issues with the update, which turned out to be particular to our site and not an actual module bug. While I was debugging, though, I re-installed the module and realized that the actual install schema isn't updated.

If anybody installs this module for the first time, they won't actually get the varchar(1024).

Sorry if this is fixed elsewhere, just thought I'd make a patch in case it isn't.

chrisck’s picture

chrisck
he/him
Location BC, Canada
commented

@asherry Thanks for spotting this. Sorry I missed this in the original MR. As this issue is closed (fixed) I created a new follow up issue #3381746 with a new MR and tagged you there.

pnavarrr’s picture

pnavarrr commented

Using Drupal 10.1.5 and module version 2.1.3. The patch it's working for me.