Problem/Motivation

User emails like "Password forgotten" are empty - no subject and no body with a fresh symfony_mailer 1.3.0 installation.
Also the mail texts form at /admin/config/people/accounts is overridden with the symfony mailer config UI
Configs at /admin/config/system/mailer/override are all disabled

I manually had to import and then disable manually again to get the default core forms at /admin/config/people/accounts and the emails to have subject and content

Now the only problem left is, that the body doesn't have line breaks, but I think that's a different issue.

Steps to reproduce

Just install the module in version 1.3.0

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Anybody created an issue. See original summary.

anybody’s picture

Title: Fresh installations user emails broken with 1.3.0 » Fresh installations user emails (e.g. password forgotten) broken with 1.3.0 missing subject and body

Something similar has already been reported here: https://www.drupal.org/project/symfony_mailer/issues/3379690#comment-151...

BTW: Composer automatically uses 1.3 (supported) instead of 1.2.2 (recommended)!

anybody’s picture

Priority: Major » Critical

All existing sites which composer upgraded to 1.3.0 are also broken now and the password forgotten emails for example don't have any value anymore. Setting priority to critical.

Is it possible to downgrade to 1.2.2 until this is fixed or are there database updates from 1.2.2 to 1.3?

anybody’s picture

Replying to myself in #3: Upgrading from 1.2.1 to 1.3 involves the following database updates:

symfony_mailer          10008       hook_update_n   10008 - Set initial
                                                      values for override
                                                      configuration.
  symfony_mailer          10009       hook_update_n   10009 - Disable the
                                                      obsolete module
                                                      symfony_mailer_bc.

And I was in luck to have that 1.2.1 installation, so I could test, if it breaks when updating to 1.3.0 and YES!
Before the update, the email subject and body were present
After the update, they are gone!

The worst part is, that composer updates to 1.3 from ^1.2 despite the not-recommended thing at Drupal.org. I don't think we can change this, so the bug itself needs to be resolved in 1.3.0

Perhaps 1.3.0 can be entirely unpublished until this is fixed, so other users don't run into the issue for now?

I just tried updating from 1.2.1 to 1.2.2: 1.2.2 still works totally fine! So the issue definitely is in 1.3.0!

anybody’s picture

FYI: I don't think #3379529: Disabled overrides should not cause conflicts but I tried if the patch fixes this issue as side-effect, but it doesn't.

anybody’s picture

Priority: Critical » Major

I finally downgraded to 1.2.2 (as I use default configuration!) by

drush pmu symfony_mailer
composer remove drupal/symfony_mailer
drush cex -y
composer require drupal/symfony_mailer:~1.2.2
drush en symfony_mailer

Be careful, this will reset all settings to default, but use 1.2.2 which works!

So as there's a workaround by reinstalling (might fit for most users without special configuration), I'm setting priority to Major.

adamps’s picture

Thanks for the report.

Your issue summary talks about fresh installations but your comment #3 talks about upgrades, so it's quite confusing. I waited until there were 700 installs of 1.3 before making a stable release, so maybe there is something specific to your site??

anybody’s picture

Hi @AdamPS, sorry for the confusion. We have both. Existing installations, which are working and fresh installations which are broken with 1.3. But what's for sure is, that there's trouble with 1.3 that wasn't there with 1.2.2. So we finally downgraded all projects, existing and fresh to 1.2.2.

The projects themselves were not fresh, but used Swiftmailer before. Please also see similar reports over here: https://www.drupal.org/project/symfony_mailer/issues/3379690

I don't know what should be specific in these projects. symfony_mailer is the only mailing module enabled on all these projects. And the issue appears with the core password forgotten emails for example (as simple test)

Most project are multilingual, but that doesn't seem to be related. The single-language projects are having the same issue with 1.3

adamps’s picture

OK I can reproduce it now, many thanks! It's a strange glitch when first on 1.3 (new site or upgrade) that will go away with some "fiddling". I think this is a workaround:

  • Go to /admin/config/system/mailer/override
  • Clear cache
adamps’s picture

adamps’s picture

Title: Fresh installations user emails (e.g. password forgotten) broken with 1.3.0 missing subject and body » Fresh installations emails broken with 1.3.0
Status: Active » Needs review
StatusFileSize
new643 bytes

Please can you test this patch?

adamps’s picture

Status: Needs review » Fixed

This patch also fixes #3379690: Update from 1.2 to 1.3 breaks existing order receipt emails and was committed on that issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mspae’s picture

Any ETA on the release containing this fix? Sites doing the Drupal 9 to 10 upgrade are affected by this.

EDIT: My bad. This was already released and I didn't see it.