Problem/Motivation

drupal.js?v=10.1.1:64 Uncaught TypeError: $(...).once is not a function
    at Object.attach (eu_cookie_compliance_hooks.js?rymm26:31:58)

Steps to reproduce

Install the EU Cookie Compliance GTM and check the browser console.

Proposed resolution

Replace jquery/once with core/once

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3378075-4.patch1.23 KBsahil.goyal
#2 3378075-before-patch.png292.88 KBsahil.goyal
#2 3378075-2.patch1.42 KBsahil.goyal

Issue fork eu_cookie_compliance_gtm-3378075

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

i-trokhanenko created an issue. See original summary.

sahil.goyal’s picture

sahil.goyal commented
Status: Active » Needs review
Issue tags: +@deprecated
StatusFileSize
new 3378075-2.patch1.42 KB
new 3378075-before-patch.png292.88 KB

Here is the updated patch resolving the deprecated the jquery/once which replaces it and makes use of the core/once library. Moving to NR.

keshavv’s picture

keshavv commented

@sahil.goyal No need to comment the existing code. Just do the replacement and we are good to merge.
Thank you.

sahil.goyal’s picture

sahil.goyal commented
StatusFileSize
new 3378075-4.patch1.23 KB

My bad, forgot to remove commented code while working on, Here is the updated patch.

keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

@sahil.goyal. Now it looks good. We can go with it.
Thank you.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented

Patch #4 works well for me. Thanks!

reszli made their first commit to this issue’s fork.

reszli opened merge request !5

  • reszli committed 494f8e7a on 2.x authored by sahil.goyal 
    Issue #3378075 by sahil.goyal: Uncaught TypeError: $(...).once is not a...
reszli’s picture

reszli
he/him
Primary language Hungarian
Location Târgu Mureș
commented
Status: Reviewed & tested by the community » Fixed

thanks for the contribution
part of 2.1.0 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.