Problem/Motivation

Shouldn't we need a composer.json in this project?
I know, it isn't strictly needed because this theme doesn't need any other "requirements" but it should be convenient for composer to work more smoothly. Especially to find out if this is a module or a theme. It can find this info under the "type" tag.
I have made sample that could be used:

{
  "name": "drupal/danland",
  "type": "drupal-theme",
  "description": "Provides Danland theme",
  "keywords": ["Drupal"],
  "license": "GPL-2.0+",
  "homepage": "https://www.drupal.org/project/danland",
  "minimum-stability": "dev",
  "support": {
    "issues": "https://www.drupal.org/project/issues/danland",
    "source": "https://git.drupalcode.org/project/danland"
  },
  "require": { }
}

As said, it is not stricly needed but convenient.
Greetings and thanks for the great work.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork danland-3377042

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

EricVL created an issue. See original summary.

jcnventura’s picture

jcnventura
Primary language English
commented
Title: Shouldn"t we add a new composer.json to this theme before the next version is been released? » Add composer.json
sunidhinegi31’s picture

sunidhinegi31 commented
Assigned: Unassigned » sunidhinegi31

chetan 11 made their first commit to this issue’s fork.

chetan 11 opened merge request !3

ericvl’s picture

ericvl
Primary language Dutch
Location Vichte, Belgium
commented

What a pitty the composer.json only specifies a required drupal/core of 8.* or 9.* and not version 10.*.
Is it possible to adapt this?
Thanks

chetan 11’s picture

chetan 11 commented

Hi @EricVL, can't add D10 version because module is not compatible with Drupal 10.

ericvl’s picture

ericvl
Primary language Dutch
Location Vichte, Belgium
commented

@chetan 11
I know this module is not D10 compatible but adding a composer.json file should be part of making this module compatible with D10.
Therfore I've first added this requiest to this issue but according to @jcnventura this was not the correct issue to ask for a composer.json.
Therfore i have made a new one - this one here.
So, could somebody add this composer.json file together with the solution to make this module D10 compatible, please.
Thank you

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Needs work

Please remove the "composer/installers": "^1.8" requirement, as that is not really needed by the theme. It is needed by the drupal project module that will take care of making sure that core and any modules/themes get installed to the right place.

jcnventura’s picture

jcnventura
Primary language English
commented

@EricVL, yes and this here should add the composer.json supporting only D8 and D9. The D10 issue should then make sure to add the D10 support to this file.

chetan 11’s picture

chetan 11 commented
Status: Needs work » Needs review
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Needs work

Actually now that I've paid better attention to this, there is a lot here that should be removed. Namely:

  • authors: Who is Lokesh Sahu? Please remove the entire section. This is better tracked in the drupal.org homepage of the theme
  • repositories: not needed
  • require: The whole section can be removed, as the drupal core support is injected by the drupal.org packagist from the information in the .info.yml file

Also, license must be a valid SPDX identifier (GPL-2.0-or-later).

jcnventura closed merge request !3

  • jcnventura committed c2722bef on 8.x-1.x 
    Issue #3377042 by chetan 11, jcnventura: Add composer.json
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.