Problem/Motivation

Claro: Views row weight should be a select list

Steps to reproduce

1. Go to any view page, admin/structure/views/view/articles_aside
2. Rearrange filter or sort criteria.
3. Now you can see the weight field is input type text.

Before Patch

Proposed resolution

Row weight field in views should be a select list.

Remaining tasks

User interface changes

CommentFileSizeAuthor
#4 Screenshot from 2023-07-26 16-34-14.png37.4 KBkostyashupenko
#2 3376372-2.patch1.42 KBgauravvvv
Screenshot 2023-07-23 at 2.57.08 PM.png153.41 KBgauravvvv

Issue fork drupal-3376372

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3376372-2.patch1.42 KB

I have changed the textfield for weight to select list, attached patch for same. please review thanks

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Can we add a simple assertion to check if it's a select list.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs tests
StatusFileSize
new Screenshot from 2023-07-26 16-34-14.png37.4 KB

Alt

Patch is working

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

What happens if someone has set arbitrary numerical values for the weight using the textfield? Wouldn't that break when we change to a select?

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Moving to NW as the tests tag was removed without adding anything

gauravvvv’s picture

gauravvvv commented

Hi @lauriii, if we input an arbitrary numerical value in the weight using a text field, it automatically adjusts to the closest available value. For example, if we enter 15.2, it will change to 15, or to the next available value if any are present before 15.

Mithun S made their first commit to this issue’s fork.

Mithun S opened merge request !8375

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Title: Claro: Views row weight should be a select list » Views row weight should be a select list

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

quietone’s picture

quietone commented
Status: Needs work » Postponed
smustgrave’s picture

smustgrave commented
Project: Drupal core » Claro
Version: main » 3.0.x-dev
Component: Claro theme » Code
Status: Postponed » Postponed (maintainer needs more info)

Claro has moved to contrib

Not sure I agree with it needing to be a dropdown? What's the reason?