Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
tour.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jul 2023 at 02:09 UTC
Updated:
10 Sep 2023 at 05:26 UTC
Jump to comment: Most recent
Tour is being deprecated, see the parent issue for details. This issue is for removing tour from the umami profile.
For an example see how this was done for the RDF module in #3243121: Remove RDF module from the Standard profile.
Remove Tour module from the Umami profile.
TBA
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
smustgrave commentedSo umami had css and a config file.
I deleted the CSS and moved the config file.
Also moved the one test function that was related to tour
Comment #5
smustgrave commentedWonder if this needs sign off from Umami maintainer.
Comment #6
smustgrave commentedSo moving the config is the issue. But not sure what to do for it.
Comment #7
larowlanMoving the config to optional feels appropriate to me
Comment #8
smustgrave commentedThat’s what I did but the config has a dependency to demo_umami module. Should this config be deleted?
Comment #9
smustgrave commentedWent ahead and deleted the config. demo_umami isn't a module that I can tell. And the workflow would have to be
Someone installs umami
Download contrib tour
Not sure tour as a contrib really should maintain config for a demo profile.
Comment #10
markconroy commentedThanks for working on this. I've no issue with our Tour items being removed if Tour is being removed from core. But let's definitely not support Tour as a contrib module in our demo_umami profile - so let's remove _all_ of Tour from Umami and not have some of it supported via "optional" config.
Comment #11
andypostComment #12
smustgrave commented@andypost think all the tour stuff has been removed
Comment #13
andypostInstead of removal the Umami's tour could live in optional config of the module
core/profiles/demo_umami/config/install/tour.tour.umami-front.ymlComment #14
smustgrave commentedSo I tried that but I couldn't get around https://www.drupal.org/pift-ci-job/2722966
Comment #15
andypostReverted commit with removal - that's just a test which needs more fixes, so I excluded the profile and added todo to existing issue #2834250: Core schema tests (DefaultConfigTest and TestViewsTest) can't reliably check contrib.
Comment #16
smustgrave commentedWorks for me
Started CR here https://www.drupal.org/node/3377475 (just copied Standard CR)
Comment #17
lauriiiAdded comment to the MR.
I don't think we actually need CR for this since this should not impact anyone. Umami is the demo experience and we are allowed to change that as we see fit.
Comment #18
andypostremoved test
Comment #19
smustgrave commentedBack to RTBC
Comment #20
catchMoving to needs work for the test restoration.
Comment #21
smustgrave commentedSo instead of writing a new test module just used the toolbar module. Locally this passed.
Comment #22
spokjeThanks @smustgrave, all threads answered, code changes look OK to me => RTBC
Comment #23
longwaveCommitted 12be8e7 and pushed to 11.x. Thanks!
Does not backport cleanly to 10.1.x due to PerformanceTest, so let's just leave tour in Umami in 10.1.x, it doesn't harm anything.
Comment #26
quietone commentedPublished the change record.