Problem/Motivation

#3265546: Drupal\KernelTests\Config\DefaultConfigTest throws deprecation notice for deprecated Core modules/themes which have config skips testing for deprecated modules. That's not necessary -- we can just test the deprecated modules in separate methods marked legacy.

Proposed resolution

  • Abstract most of DefaultConfigTest into a base class.
  • Make one child class that runs the test methods for regular modules.
  • Make another child class marked @group legacy that runs the test methods for deprecated modules. Document that it is a test of deprecated module functionality and should not be removed in cleanups of deprecations.

Remaining tasks

TBD

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3270445

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm created an issue. See original summary.

xjm opened merge request !1992

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review

Did not run locally because this test takes approximately 18 years.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Needs work

Turns out that after the 18 years passed TestBot is not happy.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Status: Needs work » Needs review

Hopefully fixed now but we'll see what the bot says. :P

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

For some reason DefaultConfigTest is still tripping a deprecation notice for HAL. Will investigate later.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.