Problem/Motivation

While working on the parent issue #3362898: Password input width is incoherent and overflows, we found that password-confirm class is used twice.

Steps to reproduce

1. Go to /admin/people/create page.
2. Search for password-confirm class.

Proposed resolution

Update password confirm class on pass2 password input by password-confirm-field and js-password-confirm to js-password-confirm-field

Remaining tasks

Patch
Review
Commit

User interface changes

NA

API changes

NA

Data model changes

NA

Release notes snippet

CommentFileSizeAuthor
#7 interdiff-3-5.txt558 bytessmustgrave
#5 3374124-5.patch10.76 KBsakthi_dev
#3 interdiff-2_3.txt620 bytesgauravvvv
#3 3374124-3.patch10.06 KBgauravvvv
#2 3374124-2.patch10.03 KBgauravvvv

Comments

Gauravvvv created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3374124-2.patch10.03 KB

I have replaced password-confirm class with password-confirm-field, Also js-password-confirm with js-password-confirm-field

Please review

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3374124-3.patch10.06 KB
new interdiff-2_3.txt620 bytes

Fixed the build failure, attached interdiff for same.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Seems to be another instance in claro_preprocess_form_element__password_confirm

sakthi_dev’s picture

sakthi_dev commented
Status: Needs work » Needs review
StatusFileSize
new 3374124-5.patch10.76 KB

Please review.

gauravvvv’s picture

gauravvvv commented

@sakthi_dev, Please add interdiff with #3.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff-3-5.txt558 bytes

Here's the interdiff missing from #5

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work 
--- a/core/lib/Drupal/Core/Render/Element/PasswordConfirm.php
+++ b/core/lib/Drupal/Core/Render/Element/PasswordConfirm.php

@@ -85,7 +85,7 @@ public static function processPasswordConfirm(&$element, FormStateInterface $for
-        'class' => ['password-confirm', 'js-password-confirm'],
+        'class' => ['password-confirm-field', 'js-password-confirm-field'],

This doesn't impact just Claro. We should either add a BC layer for this in Stable, or make the change in Claro theme.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.