[1.0.x] Entity Field Capitalization

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Please set the branch 1.0.x as default so that it will be easy for other reviewers

Please fix the below PHPCS issues:

FILE: /entity_field_capitalization/README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 107 characters
-----------------------------------------------------------------------------------


FILE: /entity_field_capitalization/entity_field_capitalization.routing.yml
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
 7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user
   |         | can change something - rather than "access administration pages" which is about viewing but not changing
   |         | configurations.
-------------------------------------------------------------------------------------------------------------------------------


FILE: /entity_field_capitalization/src/Form/EntityCapitalizationConfigForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
 37 | WARNING | #description values usually have to run through t() for translation
 46 | WARNING | #description values usually have to run through t() for translation
---------------------------------------------------------------------------------------------------------------------


FILE: /entity_field_capitalization/entity_field_capitalization.module
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 45 | WARNING | Unused variable $company_titles.
------------------------------------------------------------------------------------------------------------

Added patch for the PHPCS issues mentioned in #4, please review it.

Thanks!

@mrinalini9 Reviewers don't provide patches to fix what reported in a review.

The applicant needs to make changes on their own.

@Dharmendra.s, I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

I would suggest you to create configuration field on content type or entity level
If we want to add this functionality in lot of enity type then single textarea field will be complex.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.